Skip to content
This repository has been archived by the owner on Feb 5, 2023. It is now read-only.

Compatibility with Scout 4 #99

Merged
merged 1 commit into from
Apr 22, 2018

Conversation

kronthto
Copy link
Contributor

@kronthto kronthto commented Apr 8, 2018

As proposed in #95 (comment), the patch that allows installation with laravel/scout v4.

There are some breaking changes from Scout v3 -> v4, but AFAIK they only affect the interaction of an actual Laravel-project with Scout. I couldn't find any issues from an Engine developers POV that would require further adjustments to this projects code.

The Unit-Tests still pass and I also tested it in one of my own projects without noticing issues.

If you pull this in, I think it is enough to tag it as a minor/feature update, as the possibly breaking changes come from laravel/scout, not this package. People using laravel/scout should have it manually required with proper contraints.

@kronthto kronthto mentioned this pull request Apr 8, 2018
@amsoell
Copy link

amsoell commented Apr 8, 2018

Agree with @kronthto — we've been using a fork of this branch, with only the composer.json file modified, and it works fine. Would love to get back to using the main source.

@jonathanpmartins
Copy link

jonathanpmartins commented Apr 20, 2018

appears to be an abandoned repo

@kronthto
Copy link
Contributor Author

appears to be an abandoned repo

@ErickTamayo can you please provide a short update whether you plan to maintain this repo anymore?

This is a good package with quite some reputation (stars), I think it would be a pity if we needed to continue development on a fork starting from zero, because people would hardly find it.

Sorry for stalking, but looking at your profile you committed things to GitHub yesterday, so I hope you get this message/notification.

@ErickTamayo ErickTamayo merged commit a8e5be7 into ErickTamayo:master Apr 22, 2018
@ErickTamayo
Copy link
Owner

@kronthto sorry about the delay.

IllyaMoskvin added a commit to art-institute-of-chicago/laravel-scout-elastic that referenced this pull request May 4, 2018
Merging from upstream to add compatibility with laravel/scout ^4.0.

ErickTamayo/laravel-scout-elastic#99
ErickTamayo/laravel-scout-elastic#95
@kronthto kronthto deleted the feature/scout-4 branch August 26, 2018 15:44
sonnysantino pushed a commit to sonnysantino/laravel-scout-elastic that referenced this pull request Jan 17, 2020
* Updating 0.0.1 (ErickTamayo#8)

* fixing config key + updating the Usage on README (ErickTamayo#6)

* Rename ElasticsearchEngineTets.php to ElasticsearchEngineTest.php (ErickTamayo#7)

* Updating 0.0.1 (ErickTamayo#11)

* fixing config key + updating the Usage on README (ErickTamayo#6)

* Rename ElasticsearchEngineTets.php to ElasticsearchEngineTest.php (ErickTamayo#7)

* Update ElasticsearchEngine.php (ErickTamayo#10)

* Updating 0.0.1 (ErickTamayo#14)

* fixing config key + updating the Usage on README (ErickTamayo#6)

* Rename ElasticsearchEngineTets.php to ElasticsearchEngineTest.php (ErickTamayo#7)

* Update ElasticsearchEngine.php (ErickTamayo#10)

* optimized creation of params array for better performance when dealing with huge amount of models (ErickTamayo#13)

* Make stable (ErickTamayo#18) (ErickTamayo#19)

* Bumped Scout version to v2.0.x
Bumped elasticsearch/elasticsearch to v5.0

* Bumped Scout version to 3.0

* Fix config name (ErickTamayo#35)

* v3.0.2

bumping to php 5.6.6 (Earliest version that can support php elasticsearch) (ErickTamayo#48)
`within` now is being taken into account when specified ErickTamayo#31
Now if the record is not found on the db will not throw undefined offset ErickTamayo#36
Implemented orderBy ErickTamayo#46

* Update ElasticsearchProvider.php (ErickTamayo#54)

use `app` instead of `resolve` to make lumen 5.4 compatible.

`app` and `resolve` are identical since 5.4, see https://github.com/laravel/framework/blob/5.4/src/Illuminate/Foundation/helpers.php#L690

* chain `values` method in `map` function (ErickTamayo#66)

In 
```php
    collect($results['hits']['hits'])->map(function ($hit) use ($model, $models) {
            return isset($models[$hit['_id']]) ? $models[$hit['_id']] : null;
        })->filter();
```
would generate some holds which would cause `paginate` results objects rather than list.

* Support for "WHERE IN" searches if array is passed to `where` (ErickTamayo#55)

Right now passing an array results in: "illegal_state_exception: Can't get text on a START_ARRAY"
Solution based on http://stackoverflow.com/a/40737488/7362396

* Execute the callback that can be passed to the Builder in performSearch (ErickTamayo#56)

Context: laravel/scout#111

Implementation analogical to the official AlgoliaEngine implementation: https://github.com/laravel/scout/blob/v3.0.3/src/Engines/AlgoliaEngine.php#L112-L119

* Update ElasticsearchEngine.php (ErickTamayo#51)

Predefine elastic variable.

* Enable Laravel5.5 package Auto-Discovery (ErickTamayo#81)

* Removed count function. Fixes ErickTamayo#80 (ErickTamayo#84)

Since php 7.2, count a number will generate a warning. Because
$results['hits']['total'] is a number we can just compare it to zero.

`if ($results['hits']['total'] === 0)`

* Allow installation with Scout 4 (ErickTamayo#99)

* Compatibility with Scout 5 (ErickTamayo#106)

* Compatibility with Scout 5

No "cross-installation" possible due to changed method signature

Pass around new $builder var

Also: Use getScoutModelsByIds/getScoutKey

Inspired by laravel/scout@4.0...5.0#diff-f2faa85f27580a9b67d73a8a273bfef1 / laravel/scout@9f06b9c

* Remove PHP5 as laravel/scout^5 / laravel5.6 also removed it

* Added support for Laravel Scout 6.0 and 7.0, Laravel 5.8 (ErickTamayo#119)

* Elasticsearch downgrade

Co-authored-by: Erick Tamayo <ErickTamayo@users.noreply.github.com>
Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>
Co-authored-by: Joey <joey.xf@gmail.com>
Co-authored-by: Tobias Kronthaler <kronthto@users.noreply.github.com>
Co-authored-by: Nirav <nirav.t.prajapati21@gmail.com>
Co-authored-by: Camilo <camilo.castro.cabrera@gmail.com>
Co-authored-by: Semyon Chetvertnyh <semyon.chetvertnyh@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants