[bugfix] Crash with intercept-build based compilation database #3685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruntib
added
CLI 💻
bruntib
force-pushed
the
intercept_skip_file
branch
from
9e6b87c
to
9314258
Compare
bruntib
changed the title
bruntib
force-pushed
the
intercept_skip_file
branch
5 times, most recently
from
946640f
to
9acc82c
Compare
Szelethus
requested changes
Nov 8, 2022
| @@ -851,6 +852,22 @@ def __get_result_source_files(metadata): | |||
| return result_src_files | |||
|
|
|||
|
|
|||
| def __transform_compile_commands(compile_commands): | |||
There was a problem hiding this comment.
With respect, you could've named this function process_compile_commands, reparse_compilation_database, adjust_compcoms, or simply function_234534_by_bruntib. :)
How about we call this change_args_to_command_in_comp_db or something more specific?
| """ | ||
| In CodeChecker we support compilation databases where the JSON object of a | ||
| build action contains "file", "directory" and "command" fields. However, | ||
| compilation databases from intercept build are contan "arguments" instead |
There was a problem hiding this comment.
Suggested change
| compilation databases from intercept build are contan "arguments" instead | |
| compilation databases from intercept build are contain "arguments" instead |
When compilation database is generated by intercept build then a build action in this JSON file contains "arguments" field instead of "command" which is a list of command-line arguments instead of a single string. CodeChecker supports only "command" field, so this transformation must be done in "CodeChecker analyze" command in order to avoid failure when building SkipHandler with "--file <header_file>" flag. Fixes Ericsson#3683
bruntib
force-pushed
the
intercept_skip_file
branch
from
9acc82c
to
d8b5edd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compilation database is generated by intercept build then a build
action in this JSON file contains "arguments" field instead of "command"
which is a list of command-line arguments instead of a single string.
CodeChecker supports only "command" field, so this transformation must
be done in "CodeChecker analyze" command in order to avoid failure
when building SkipHandler with "--file <header_file>" flag.
Fixes #3683