[cmd] Remove some deprecated flags. #3823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruntib
added
the
CLI 💻
vodorok
requested changes
Jan 20, 2023
| @@ -530,7 +530,7 @@ def add_arguments_to_parser(parser): | |||
| action='store_true', | |||
| dest='ctu_reanalyze_on_failure', | |||
| default=argparse.SUPPRESS, | |||
| help="DEPRECATED. The flag will be removed. " | |||
| help="The flag will be removed. " | |||
There was a problem hiding this comment.
Shouldn't the full line be removed:?
There was a problem hiding this comment.
Thanks, it's a nice catch. I fixed it.
| @@ -478,7 +478,7 @@ def add_arguments_to_parser(parser): | |||
| action='store_true', | |||
| dest='ctu_reanalyze_on_failure', | |||
| default=argparse.SUPPRESS, | |||
| help="DEPRECATED. The flag will be removed. " | |||
| help="The flag will be removed. " | |||
There was a problem hiding this comment.
Shouldn't the full line be removed:?
| @@ -325,16 +325,6 @@ def check_run_names(client, check_names): | |||
|
|
|||
|
|
|||
| def check_deprecated_arg_usage(args): | |||
| if 'suppressed' in args: | |||
There was a problem hiding this comment.
Was this suppressed param already a no-op?
There was a problem hiding this comment.
Yes, it was not used. --review-status is used instead.
Some flags are removed from the code base that are deprecated for a while. Also, the deprecation of --ctu-reanalyze-on-failure is undone, because it will not be deprecated in the near future, probably.
bruntib
force-pushed
the
deprecated_flags
branch
from
2071442
to
e2545b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some flags are removed from the code base that are deprecated for a while.
Also, the deprecation of --ctu-reanalyze-on-failure is undone, because it will not be deprecated in the near future, probably.