-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmd] Remove some deprecated flags. #3823
Conversation
@@ -530,7 +530,7 @@ def add_arguments_to_parser(parser): | |||
action='store_true', | |||
dest='ctu_reanalyze_on_failure', | |||
default=argparse.SUPPRESS, | |||
help="DEPRECATED. The flag will be removed. " | |||
help="The flag will be removed. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the full line be removed:?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it's a nice catch. I fixed it.
@@ -478,7 +478,7 @@ def add_arguments_to_parser(parser): | |||
action='store_true', | |||
dest='ctu_reanalyze_on_failure', | |||
default=argparse.SUPPRESS, | |||
help="DEPRECATED. The flag will be removed. " | |||
help="The flag will be removed. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the full line be removed:?
@@ -325,16 +325,6 @@ def check_run_names(client, check_names): | |||
|
|||
|
|||
def check_deprecated_arg_usage(args): | |||
if 'suppressed' in args: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this suppressed param already a no-op?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it was not used. --review-status
is used instead.
Some flags are removed from the code base that are deprecated for a while. Also, the deprecation of --ctu-reanalyze-on-failure is undone, because it will not be deprecated in the near future, probably.
2071442
to
e2545b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Some flags are removed from the code base that are deprecated for a while.
Also, the deprecation of --ctu-reanalyze-on-failure is undone, because it will not be deprecated in the near future, probably.