Issue 397 Metric reporter to log debug messages if configured number … #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of repairs have failed
jwaeab
requested changes
May 15, 2024
...ation/src/main/java/com/ericsson/bss/cassandra/ecchronos/application/ECChronosInternals.java
Outdated
Show resolved
Hide resolved
...ation/src/main/java/com/ericsson/bss/cassandra/ecchronos/application/ECChronosInternals.java
Outdated
Show resolved
Hide resolved
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Show resolved
Hide resolved
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Outdated
Show resolved
Hide resolved
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/utils/TestStatusLogger.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/utils/TestStatusLogger.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/utils/TestStatusLogger.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/utils/TestStatusLogger.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/utils/TestStatusLogger.java
Outdated
Show resolved
Hide resolved
|
Hi Johan, I still need to address some comments from Macan and also need to write more test cases. |
|
Johan added the test cases and made some changes as per some comments by Makan. You can proceed with review. |
jwaeab
requested changes
Jun 3, 2024
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Outdated
Show resolved
Hide resolved
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Outdated
Show resolved
Hide resolved
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Outdated
Show resolved
Hide resolved
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Outdated
Show resolved
Hide resolved
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/metrics/TestMetricInspector.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/metrics/TestMetricInspector.java
Show resolved
Hide resolved
core/src/main/java/com/ericsson/bss/cassandra/ecchronos/core/metrics/MetricInspector.java
Show resolved
Hide resolved
...ation/src/main/java/com/ericsson/bss/cassandra/ecchronos/application/ECChronosInternals.java
Outdated
Show resolved
Hide resolved
...ation/src/main/java/com/ericsson/bss/cassandra/ecchronos/application/ECChronosInternals.java
Outdated
Show resolved
Hide resolved
|
Documentation updatated, comments addressed. |
jwaeab
requested changes
Jun 10, 2024
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Outdated
Show resolved
Hide resolved
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/ericsson/bss/cassandra/ecchronos/core/metrics/MetricInspector.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/ericsson/bss/cassandra/ecchronos/core/metrics/MetricInspector.java
Show resolved
Hide resolved
|
Hi Johan I have closed all review comments. |
jwaeab
approved these changes
Jun 17, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
jwaeab
requested changes
Jun 17, 2024
jwaeab
previously approved these changes
Jun 17, 2024
tommystendahl
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metric inspector to read metrices every 5 seconds. It will check if number of failed repairs in a time window (default 30 minutes) exceed to that configured value in yaml file. If identifies that there are these many repairs in defined time window, then debug messages are printed with some of the metrices,showing status of the system at that moment. Also the timewindow is reconfigured to start next time window.