-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 397 Metric reporter to log debug messages if configured number … #662
Conversation
…of repairs have failed
...ation/src/main/java/com/ericsson/bss/cassandra/ecchronos/application/ECChronosInternals.java
Outdated
Show resolved
Hide resolved
...ation/src/main/java/com/ericsson/bss/cassandra/ecchronos/application/ECChronosInternals.java
Outdated
Show resolved
Hide resolved
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Show resolved
Hide resolved
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Outdated
Show resolved
Hide resolved
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/utils/TestStatusLogger.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/utils/TestStatusLogger.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/utils/TestStatusLogger.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/utils/TestStatusLogger.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/utils/TestStatusLogger.java
Outdated
Show resolved
Hide resolved
Hi Johan, I still need to address some comments from Macan and also need to write more test cases. |
Johan added the test cases and made some changes as per some comments by Makan. You can proceed with review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing documentation of this feature.
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Outdated
Show resolved
Hide resolved
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Outdated
Show resolved
Hide resolved
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Outdated
Show resolved
Hide resolved
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Outdated
Show resolved
Hide resolved
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/metrics/TestMetricInspector.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/metrics/TestMetricInspector.java
Show resolved
Hide resolved
core/src/main/java/com/ericsson/bss/cassandra/ecchronos/core/metrics/MetricInspector.java
Show resolved
Hide resolved
...ation/src/main/java/com/ericsson/bss/cassandra/ecchronos/application/ECChronosInternals.java
Outdated
Show resolved
Hide resolved
...ation/src/main/java/com/ericsson/bss/cassandra/ecchronos/application/ECChronosInternals.java
Outdated
Show resolved
Hide resolved
Documentation updatated, comments addressed. |
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Outdated
Show resolved
Hide resolved
...n/java/com/ericsson/bss/cassandra/ecchronos/application/config/metrics/StatisticsConfig.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/ericsson/bss/cassandra/ecchronos/core/metrics/MetricInspector.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/ericsson/bss/cassandra/ecchronos/core/metrics/MetricInspector.java
Show resolved
Hide resolved
Hi Johan I have closed all review comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update CHANGES.md as well as have a look at the conflicts
Metric inspector to read metrices every 5 seconds. It will check if number of failed repairs in a time window (default 30 minutes) exceed to that configured value in yaml file. If identifies that there are these many repairs in defined time window, then debug messages are printed with some of the metrices,showing status of the system at that moment. Also the timewindow is reconfigured to start next time window.