-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make offer generated by "createOffer" spec compliant #62
Comments
I am investigating if we can get https://github.com/strukturag/spreed-webrtc working with Bowser. This was one of the first issues i saw. |
Any progress? |
At least I've not heard of any progress so far. |
It has been a few more months, any more word on this? |
I think an update to libnice is needed. I don't know if anyone looked into On Tue, Feb 17, 2015 at 6:51 AM, Stefan Ålund notifications@github.com
|
Maybe Olivier Crete knows. Describe the issue in an email an I can forward it. |
I asked on the libnice list: http://lists.freedesktop.org/archives/nice/2015-February/001072.html |
Somebody submitted a patch on the libnice list, see link above. |
Current (from App store) version of Bowser run on IPhone6. sdp: "v=0 |
Now being tracked here: https://bugs.freedesktop.org/show_bug.cgi?id=89839 |
Follow up: the freedesktop bug is part of the problem, but there is more to it (e.g. the offer created should contain ssrc info, mid, ....) |
Any updates of this issue? I see that the bug from freedesktop was fixed. Just tested in Safari (with owr) and the following offer is generated: While in chrome the offer is: We need at least ICE-ufrag and password. |
@stefhak - if we update libnice to pull in the _set_local_credentials patch, do you think you can implement the remaining parts in OpenWebRTC? |
With some help I think I could manage that. On Sun, Apr 26, 2015 at 12:17 PM, Robert Swain notifications@github.com
|
Then I'll look into updating libnice after the release tomorrow. |
@stefhak, libnice is updated in cerbero to 0.1.12 which includes the _set_local_credentials API. |
@stefhak any luck with this? |
I have not done anything yet. Promise to get to it next week. |
So after some discussions with people who know stuff, we've concluded that a possible way forward is to divide this into the following parts (all of which are needed to make the offer spec compliant):
|
SSRC should be set in the capsfilter caps after the RTP payloader. cname can be set on the internal RTPSession's sdes property. That property is a GstStructure which has key=value fields as follows: http://cgit.freedesktop.org/gstreamer/gst-plugins-good/tree/gst/rtpmanager/rtpsource.c#n99 When requesting a new pad on rtpbin, the RTPSource and RTPSession will be created. After that, you can use the get-internal-session action signal ( http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-good-plugins/html/gst-plugins-good-plugins-rtpbin.html#GstRtpBin-get-internal-session ) to get the RTPSession object and then create the appropriate SDES GstStructure and set it on the RTPSession. If the cname is the same for all sessions, the structure can be set on the rtpbin sdes property. |
Make ssrc and cname properties writable: #398 Though I still need to look at RTX SSRC stuff (whether we're signalling it correctly and how to set it.) |
So, I think we need an rtx-ssrc property somewhere and then we need to correctly handle the ssrc-map signal from rtprtxsend and rtprtxreceive to map the payload types to ssrcs. |
@superdump, see the ssrc-map property on rtprtxsend. |
Done #427 |
I think the only part remaining is to check and fix is the RTX SSRC bit. |
Should we reopen or create a separate, new, issue? |
I'll reopen this as the information is above. |
We can do that, but I think being able to set MID has higher prio. On Thu, Oct 22, 2015 at 6:43 PM, Stefan Ålund notifications@github.com
|
@stefhak: do you have any list of compliance issues? |
I'll work on one. On Thu, Oct 22, 2015 at 6:48 PM, Robert Swain notifications@github.com
|
OK, I've changed my mind. I think we can close this and consider the original issue with createOffer compliance completed. The RTX stuff can be added later. See here: #492 |
Offers generated now miss ICE-ufrag and password as well as DTLS fingerprint, meaning they can't be sent to the other side (you have to do setLocal and fetch the local config and send that one).
According to the spec you should be able to send the offer generated by createOffer (it should be complete with ufrag, pw and fingerprint). We should fix this.
The text was updated successfully, but these errors were encountered: