Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTP bundling support #656

Closed
wants to merge 3 commits into from
Closed

RTP bundling support #656

wants to merge 3 commits into from

Conversation

philn
Copy link
Contributor

@philn philn commented Nov 14, 2016

This pull-request depends on #653 and https://bugzilla.gnome.org/show_bug.cgi?id=772740

alexgcastro and others added 3 commits November 14, 2016 12:22
This is required for the proper RTX implementation.
We now differentiate session IDs and stream IDs. The streams represent
what goes from/to the Nice GStreamer elements. When SDP bundle have been
negotiated with a peer, the transport agent will now create a single
Nice src and sink elements. If RTCP muxing is enabled, the RTCP packets
will flow through these elements. Otherwise, new dedicated Nice src and
sink elements are created.
@philn
Copy link
Contributor Author

philn commented Nov 16, 2016

https://bugzilla.gnome.org/show_bug.cgi?id=772740 is now solved :)

@stefhak
Copy link
Contributor

stefhak commented Nov 20, 2016

Does this PR also address bundling for the data channel?

@philn
Copy link
Contributor Author

philn commented Nov 20, 2016

Hum no it doesn't. We barely started working on data channel support for WebKit actually :)

@stefhak
Copy link
Contributor

stefhak commented Nov 20, 2016

Well, I don't see that as a reason for not adding support for media. So I support merging this PR.

@philn
Copy link
Contributor Author

philn commented Dec 26, 2018

The corresponding API was removed from GStreamer's rtpbin. Closing.

@philn philn closed this Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants