Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert EF Core 8 navigation naming fix #2143

Closed
4 tasks done
ErikEJ opened this issue Feb 5, 2024 · 7 comments · Fixed by #2145
Closed
4 tasks done

Revert EF Core 8 navigation naming fix #2143

ErikEJ opened this issue Feb 5, 2024 · 7 comments · Fixed by #2145
Labels
enhancement New feature or request reveng reveng-cli

Comments

@ErikEJ
Copy link
Owner

ErikEJ commented Feb 5, 2024 •
edited

  • Try in VS extension
  • Collect feedback
  • Add to CLI
  • Document

dotnet/efcore#32981 (comment)
@ErikEJ ErikEJ mentioned this issue Feb 5, 2024
Closed
@ErikEJ
Copy link
Owner Author

ErikEJ commented Feb 5, 2024

@hallidev @bclementfidx
I plan to make this an opt-in to not break too many users.

"UseLegacyNavigationNaming" for example

@hallidev
Copy link

hallidev commented Feb 5, 2024

I recommend "UseImprovedNavigationNaming" but "Legacy" works too :)

@ErikEJ
Copy link
Owner Author

ErikEJ commented Feb 6, 2024

I am considering "UsePrefixNavigationNaming" ...

ErikEJ added a commit that referenced this issue Feb 6, 2024
@ErikEJ
Add support for prefix naming in EF Core 8
d446be6 
relates to #2143
@ErikEJ ErikEJ mentioned this issue Feb 6, 2024
Merged
ErikEJ added a commit that referenced this issue Feb 6, 2024
@ErikEJ
Add support for prefix naming in EF Core 8 (#2144)
713f1b4 
relates to #2143
@ErikEJ
Copy link
Owner Author

ErikEJ commented Feb 6, 2024 •
edited

@hallidev @bclementfidx

I implemented a fix for this in the latest daily build, would be grateful if you could try it out.

(There is no UI for the feature, you must manually edit the efpt.config.json file)

ErikEJ added a commit that referenced this issue Feb 6, 2024
@ErikEJ
Add prefix naming support to CLI
b8c81b3 
fixes #2143
@ErikEJ ErikEJ mentioned this issue Feb 6, 2024
Merged
ErikEJ added a commit that referenced this issue Feb 6, 2024
@ErikEJ
Add prefix naming support to CLI (#2145)
0633263 
fixes #2143
@bclementfidx
Copy link

This worked for me, appreciate it! A lot of our devs use the cli.. so we're hoping the efcore team will revert this soon

@ErikEJ
Copy link
Owner Author

ErikEJ commented Feb 7, 2024

@bclementfidx This fix is also included the EF Core Power Tools CLI!

@ErikEJ
Copy link
Owner Author

ErikEJ commented Feb 11, 2024

@lupusbytes FYI

@ErikEJ ErikEJ reopened this Mar 21, 2024
@ErikEJ ErikEJ closed this as completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request reveng reveng-cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add prefix naming support to CLI ErikEJ/EFCorePowerTools
3 participants
@ErikEJ @hallidev @bclementfidx