Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some classes from Internal to public #19

Closed
LindebergC opened this issue Jan 2, 2024 · 4 comments
Closed

Change some classes from Internal to public #19

LindebergC opened this issue Jan 2, 2024 · 4 comments

Comments

@LindebergC
Copy link

I have some clients that used https://github.com/vnbaaij/ImageProcessor.Web.Episerver for cms 11, that used some methods in PictureUtils.

It would be nice to be able to use some of the methods in the class PictureUtils but the class is Internal, would it be possible to change that to public for PictureUtils and PictureData?

@ErikHen
Copy link
Owner

ErikHen commented Jan 2, 2024

Hi. Sure, that can be done. What methods do you want to use?

@LindebergC
Copy link
Author

Wonderful! :)

Mainly GetPictureData, but that is already public but I was thinking of

internal static class PictureUtils

to
public static class PictureUtils

and
internal class PictureData

to
public class PictureData

@ErikHen
Copy link
Owner

ErikHen commented Jan 4, 2024

Hi. Update to v3.11 and see if that works for you.
I'm curious why you want to do this. Do you render an img/picture element yourself?

@LindebergC
Copy link
Author

Thank you Erik! It works like a charm!

Yes you are right, in some places I need to render just the img element, one example is for the meta property="og:image" for facebook.

@ErikHen ErikHen closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants