Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return vars from api response #32

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Return vars from api response #32

merged 3 commits into from
Jul 7, 2023

Conversation

dyfero
Copy link
Contributor

@dyfero dyfero commented Jul 7, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #32 (04fea1c) into main (96fbfc7) will decrease coverage by 0.57%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##               main      #32      +/-   ##
============================================
- Coverage     84.46%   83.89%   -0.57%     
- Complexity       74       78       +4     
============================================
  Files            22       23       +1     
  Lines           251      267      +16     
============================================
+ Hits            212      224      +12     
- Misses           39       43       +4     
Impacted Files Coverage Δ
src/Courses/CommonUserAndCourseVariables.php 70.27% <50.00%> (-5.60%) ⬇️
src/Http/Resources/PdfListResource.php 100.00% <100.00%> (ø)
src/Http/Resources/PdfResource.php 100.00% <100.00%> (ø)
src/Parsers/VarsParser.php 100.00% <100.00%> (ø)
src/Services/ReportBroService.php 81.81% <100.00%> (+0.56%) ⬆️

@dyfero dyfero requested review from mako321 and qunabu July 7, 2023 06:47
@qunabu qunabu merged commit 86c5aa3 into main Jul 7, 2023
6 of 8 checks passed
@qunabu qunabu deleted the feature/vars branch July 7, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants