Cache components, getters and constructors in RecordSerializer
#927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theigl
force-pushed
the
caching-record-serializer
branch
from
512271e
to
d30570a
Compare
|
@JanecekPetr: One last ping. Do you have any feedback on this implementation? If not, I'm going to merge this next week and release Kryo 5.4.0. |
theigl
changed the title
RecordSerializerRecordSerializer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts
RecordSerializerto cache record components, component getters and the canonical constructor. Thew new implementation is about 20x faster than the current one.The only downside is that I had to remove the existing no-args constructor. This shouldn't be a huge issue, because there was no need for any user to instantiate the
RecordSerializerthemselves.If we want to stay fully backwards compatible, we can use
ClassValuefor caching record components and constructors.