Allow the Object class to be used with MethodAccess#get(Class) #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #ade0542 primitive types, Void and the Object class were no longer allowed to be used with
MethodAccess#get(Class). This was done to mirror similar changes toFieldAccessas a fix to #59.But there actually seems to be no good reason to exclude the Object class, as there are legitimate use cases: For example this KryoNet test tries to invoke the
Object#hashCode()-Method via RMI. This requiresObjectSpaceto useMethodAccess#get(Class), where the class isObject.class.