Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the runtimes into individual repositories #2175

Closed
jasonwinterpixel opened this issue Oct 12, 2022 · 1 comment
Closed

Split the runtimes into individual repositories #2175

jasonwinterpixel opened this issue Oct 12, 2022 · 1 comment

Comments

@jasonwinterpixel
Copy link
Contributor

jasonwinterpixel commented Oct 12, 2022

To build the Godot Spine runtime as part of our fork of Godot, we are using a symlink into this repo, which is added to our game projects as a submodule. We would like to not use symlinks, and not have to check out this entire repository. The file size of cloning this repo is large (> 300MB), and symlinks in git are fragile, especially on windows. Having all the examples atlases is wasteful for us.

I recommend a more modular repository approach where each runtime is its own repo, ie:

https://github.com/EsotericSoftware/spine-godot
and
https://github.com/EsotericSoftware/spine-cpp

etc

I understand it would be a difficult task to change the repository architecture now, but I am submitting this issue to inform Esoteric of my thoughts here.

spine-godot shoud reference spine-cpp as a submodule, and not via copying.
https://github.com/EsotericSoftware/spine-runtimes/blob/4.1/spine-godot/build/setup.sh#L40

@NathanSweet
Copy link
Member

We are aware and it's been suggested before:
#758

Please see the comments there for our stance. If you don't like downloading the whole repo, you could use Git's partial/shallow clone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants