Move data files to /usr/share on Linux #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix whitespace at EOL and EOF; replace tabs * Normalize line endings
Combine the Android and non-Android implementations. Only difference now is the path to the waveform data. Remove arbitrarily-sized buffers and most C-style string handling function calls. Use native Qt string methods instead; this should improve memory safety.
Use QString::asprintf() instead of a buffer. Convert to a C string using qPrintable().
Skip installing the .exe and .bat files on Linux. Other platforms could also search QStandardPaths::AppDataLocation but I am not familiar with how they are packaged. The locations searched corresponds to $XDG_DATA_DIRS; prepend the right path to it when running from the AppImage container.
Fix the labrador -> Labrador symlink so that it's created in
${INSTALL_ROOT} when supplied; previously it was installed directly to
/usr/bin. This symlink may not be necessary anymore.
turboencabulator
force-pushed
the
paths
branch
from
18bfaa5
to
1308ebc
Compare
New list generated by matching up the output of `readelf -d /usr/bin/Labrador | grep NEEDED` with the available Debian packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic idea is to make it easier to create a native package on Linux, but the program is searching for data files relative to its own location. Instead use QStandardPaths to find the data files so we can place everything in their customary locations.
The last few commits fix some complaints by lintian for the Debian package.