Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an analyzer that detects whether UseArcGISToolkit has been added #556

Merged
merged 7 commits into from
Mar 25, 2024

Conversation

dotMorten
Copy link
Member

@dotMorten dotMorten commented Feb 28, 2024

Inspired by the CommunityToolkit analyzer:

UseAutoFix.mp4

TODO: Agree on a good analyzer error code (Currently "AMT001" for ArcGIS Maps Toolkit error 1")

@dotMorten dotMorten self-assigned this Feb 28, 2024
@dotMorten dotMorten requested a review from mstefarov March 7, 2024 18:37
@dotMorten dotMorten marked this pull request as ready for review March 7, 2024 18:37
@dotMorten dotMorten requested a review from mstefarov March 7, 2024 20:28
@dotMorten dotMorten changed the base branch from main to v.next March 25, 2024 17:32
@dotMorten dotMorten merged commit 334068b into v.next Mar 25, 2024
1 check failed
@dotMorten dotMorten deleted the usetoolkit_analyzer branch March 25, 2024 21:07
dotMorten added a commit that referenced this pull request Apr 11, 2024
* Upgrade dependencies

* FeatureFormsView (#546)

FeatureFormView for WPF

* Rename property (#547)

* FeatureForm: localized messages (#548)

* Add better localizable error messages to form validation and handle null and invalid values better
* Prep multiple resources for UWP

* Add resource manifest

* Fix slashes

* Add context to resource strings to help with translations

* Undo key rename

* Prefix scaleline resource ids

* Replace FloorFilter strings with localizable strings

* Replace SearchView strings with localizable strings

* Add markup extension for localizing strings in XAML

* Fix typo

* Update maui target versions

* Adjust to breaking design changes in FeatureForms API

* utilnet: localize trace tool

* utilnet: default to empty instead of throw, remove unncessary catch

* utilnet: add catch-all to guard against UN failing to load

* utilnet: remove localized exception messages though they affect UI.

* Handle prop changed events to validation errors (#553)

Co-authored-by: Morten Nielsen <mort5161@esri.com>

* Handle events firing on background threads

* Add missing xmlns mapping for maui

* Handle UI Thread-access issue

* Update error messages on initial load

* Update strings to avoid pluralization issues

* Remove BarcodeScannerFormInput (#563)

* Hide unsupported inputs + remove unused code

* Handle visibility changes coming from background thread

* Update validation as you type

* Adds an analyzer that detects whether UseArcGISToolkit has been added (#556)

* Adds an analyzer that detects whether UseArcGISToolkit has been added

* FeatureForm WPF: Tooltip shows even when empty (#561)

* Adding Visibility toggle based on content of `Hint` Property using VisibilityConverter

* Changing Tooltip visibility code from ValueConverter to Triggers.

* Don't sign unpackable targets

Ensure only packable projects gets signed. If built with `GeneratePackageOnBuild=true` this command would run and fail.

* FeatureForms for .NET MAUI (#564)

* Initial skeleton for maui feature forms

* SwitchInput added

* Added text inputs

* Add error border to text fields

* Added place holders for remaining input types

* Implement combobox

* Add radio button support

* Clean up

* Update enable state

* Add group expander

* Maui: Update switch enable state

* Improve group UI

* Style fixes

* indent

* More styling tweaks

* Show 0 length for null strings

* Improve switch

* Add IsValid property to MAUI

* ui fixes

* Move guarded evaluate to FeatureFormView and also use it on initialize to avoid more cancellation exceptions

* Improve group rendering

* Improve group box UI

* Use TextBlock instead to show readonly text

+ Don't show error messages when a field isn't editable

* Use extension method for dispatching

* Rename files

* Use unicode

* Remove unused code

* Preserve property

* Missing preserves

* Fix type

* Add missing INT64

* Add FFV doc

* Update doc

* Include all language resources on MAUI and WinUI as well

* feat(localization): update pseudo translation (#557)

* Update translation - @mit10976 @Isa13169 @nia13404

* Add FeatureFormView sample

* MAUI: Add DateTimePickerFormInput (#565)

* wpf: Improve keyboard navigation for FeatureForms (#567)

* Use updated URLs

* Fix version

* Fix typo

---------

Co-authored-by: Morten Nielsen <mort5161@esri.com>
Co-authored-by: Matvei Stefarov <mstefarov@esri.com>
Co-authored-by: Jennifer Nery <jnery@esri.com>
Co-authored-by: Prathamesh Narkhede <55591622+prathameshnarkhede@users.noreply.github.com>
Co-authored-by: Isaac Sesmundo <isesmundo@esri.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants