wpf: Improve keyboard navigation for FeatureForms #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotMorten
added a commit
that referenced
this pull request
Apr 11, 2024
* Upgrade dependencies * FeatureFormsView (#546) FeatureFormView for WPF * Rename property (#547) * FeatureForm: localized messages (#548) * Add better localizable error messages to form validation and handle null and invalid values better * Prep multiple resources for UWP * Add resource manifest * Fix slashes * Add context to resource strings to help with translations * Undo key rename * Prefix scaleline resource ids * Replace FloorFilter strings with localizable strings * Replace SearchView strings with localizable strings * Add markup extension for localizing strings in XAML * Fix typo * Update maui target versions * Adjust to breaking design changes in FeatureForms API * utilnet: localize trace tool * utilnet: default to empty instead of throw, remove unncessary catch * utilnet: add catch-all to guard against UN failing to load * utilnet: remove localized exception messages though they affect UI. * Handle prop changed events to validation errors (#553) Co-authored-by: Morten Nielsen <mort5161@esri.com> * Handle events firing on background threads * Add missing xmlns mapping for maui * Handle UI Thread-access issue * Update error messages on initial load * Update strings to avoid pluralization issues * Remove BarcodeScannerFormInput (#563) * Hide unsupported inputs + remove unused code * Handle visibility changes coming from background thread * Update validation as you type * Adds an analyzer that detects whether UseArcGISToolkit has been added (#556) * Adds an analyzer that detects whether UseArcGISToolkit has been added * FeatureForm WPF: Tooltip shows even when empty (#561) * Adding Visibility toggle based on content of `Hint` Property using VisibilityConverter * Changing Tooltip visibility code from ValueConverter to Triggers. * Don't sign unpackable targets Ensure only packable projects gets signed. If built with `GeneratePackageOnBuild=true` this command would run and fail. * FeatureForms for .NET MAUI (#564) * Initial skeleton for maui feature forms * SwitchInput added * Added text inputs * Add error border to text fields * Added place holders for remaining input types * Implement combobox * Add radio button support * Clean up * Update enable state * Add group expander * Maui: Update switch enable state * Improve group UI * Style fixes * indent * More styling tweaks * Show 0 length for null strings * Improve switch * Add IsValid property to MAUI * ui fixes * Move guarded evaluate to FeatureFormView and also use it on initialize to avoid more cancellation exceptions * Improve group rendering * Improve group box UI * Use TextBlock instead to show readonly text + Don't show error messages when a field isn't editable * Use extension method for dispatching * Rename files * Use unicode * Remove unused code * Preserve property * Missing preserves * Fix type * Add missing INT64 * Add FFV doc * Update doc * Include all language resources on MAUI and WinUI as well * feat(localization): update pseudo translation (#557) * Update translation - @mit10976 @Isa13169 @nia13404 * Add FeatureFormView sample * MAUI: Add DateTimePickerFormInput (#565) * wpf: Improve keyboard navigation for FeatureForms (#567) * Use updated URLs * Fix version * Fix typo --------- Co-authored-by: Morten Nielsen <mort5161@esri.com> Co-authored-by: Matvei Stefarov <mstefarov@esri.com> Co-authored-by: Jennifer Nery <jnery@esri.com> Co-authored-by: Prathamesh Narkhede <55591622+prathameshnarkhede@users.noreply.github.com> Co-authored-by: Isaac Sesmundo <isesmundo@esri.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a go using the WPF FeatureForms sample with keyboard navigation, and found that we had MANY extra tab stops between the actual inputs: on content controls, on items controls, on containers, etc. Here is the problem that this PR attempts to solve: it took 16 TAB presses to navigate through 5 fields:
This PR removes the useless intermediate tab stops, so that keyboard focus switches directly between inputs. Now it take 5 TAB presses to navigate 5 fields: