-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Setup] Initialize the project file #1
Conversation
I think it would be nice to have the Swift API added manually to the sample view for development.
|
I don't understand. What's the problem with the new format? As far as we know, it is here to stay, so using an older project version is just delaying the inevitable. And since the minimum required Xcode version is going to be at least 13.0, it will never be opened in Xcode 12. Could we embrace that change instead? By the way, as part of this PR, could you please update the README with a requirements section and also instructions to build? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yo1995 I'm very excited to see this started! I agree with @zkline101 and @philium, that the sample viewer point to the local version of the Swift API. This is what the Toolkit does and it makes it very easy to build (and debug) using the latest version. Also, embracing the Xcode 13 project format just makes sense, even though it is a bit of a hassle ATM.
Nice work!
Feel free to take another look. A few updates after I address the suggestions above:
|
Co-authored-by: Philip Ridgeway <philip.ridgeway@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you so much.
@mhdostal @zkline101 @philium (@dfeinzimer) During today's cocoa scrum Ryan raised a good point - it may be a hassle for intern Chris to set up |
This PR initialize the project from a multiplatform app template created in Xcode Version 13.3 (13E113).
Notes:
The project file is configured withEdit: the project file is nowXcode 12.0-compatible
(objectVersion = 54) project format, rather than the newest Xcode 13 format, due to Apple's new way of handlingInfo.plist
. refXcode 13.0-compatible
(objectVersion = 55), with Info.plist auto generation disabled.masquerade
mechanism which is also in current iOS SV, see New: Adding API keys with "masquerade" mechanism arcgis-runtime-samples-ios#1013 . A new placeholder API key for macOS sample viewer is included in the masque file.secrets
fileThe project is configured with local Swift package. Download the Swift API daily build and put it underEdit: according to suggestions below, the project is now manually configured with the Swift API source codeSources/Swift
- until we release the Swift API to public, local SP will be the primary way for development@main
entry file is renamed asAppMain.swift
Build Options -> Enable Previews
is disabled (default) for both iOSand macOStargets. If needed we can add it back later on. For now I won't create preview for the main app logic UI or samples to facilitate development