Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Setup] Add ArcGISToolkit dependency #4

Merged
merged 8 commits into from
May 17, 2022
Merged

[Setup] Add ArcGISToolkit dependency #4

merged 8 commits into from
May 17, 2022

Conversation

yo1995
Copy link
Collaborator

@yo1995 yo1995 commented May 13, 2022

This PR removes the local ArcGIS Swift package from the project, and add local ArcGISToolkit to the project.

Also, it includes a sample that demonstrate the toolkit capability, to verify the dependency is correctly set up.

This PR will close this card: https://github.com/ArcGIS/arcgis-runtime-samples-swift/projects/1#card-80396669

@yo1995 yo1995 self-assigned this May 13, 2022

## Additional Information

This samples uses the basemap gallery toolkit component, which requires the [ArcGIS Runtime Toolkit for Swift](https://github.com/Esri/arcgis-runtime-toolkit-swift).
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I make this URL the public URL when it goes live, so that we don't need to revisit the README at that time. Now it shows 404.

@yo1995 yo1995 marked this pull request as ready for review May 13, 2022 19:27
Co-authored-by: Zachary A Kline <zkline@esri.com>
mhdostal
mhdostal previously approved these changes May 16, 2022
yo1995 and others added 2 commits May 16, 2022 17:59
@dfeinzimer
Copy link
Contributor

I placed an API key into AppSecrets.swift.masque and verified that it's getting picked up by logging String.licenseKey but I'm not getting a map to successfully display in the "Display a map" sample.

If I add ArcGISRuntimeEnvironment.apiKey = APIKey("…") to SamplesApp.init() which is similar to what the toolkit does, I get a map to display successfully.

Is there anything I'm missing?

@yo1995
Copy link
Collaborator Author

yo1995 commented May 17, 2022

I placed an API key into AppSecrets.swift.masque and verified that it's getting picked up by logging String.licenseKey but I'm not getting a map to successfully display in the "Display a map" sample.

If I add ArcGISRuntimeEnvironment.apiKey = APIKey("…") to SamplesApp.init() which is similar to what the toolkit does, I get a map to display successfully.

Is there anything I'm missing?

Oops sorry. Please refer to the root README about API key setup: https://github.com/ArcGIS/arcgis-runtime-samples-swift/tree/v.next#configuring-api-keys basically we put the key in a separate hidden file .secrets in the root directory and exclude it from the source control.

@dfeinzimer dfeinzimer self-requested a review May 17, 2022 16:31
@yo1995 yo1995 merged commit bcef848 into v.next May 17, 2022
@yo1995 yo1995 deleted the Ting/AddToolkit branch May 17, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants