-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Set viewpoint rotation #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added map rotation SwiftUI view and docs
Only included relevant steps to change a map's rotation.
yo1995
reviewed
May 31, 2022
Shared/Samples/Set viewpoint rotation/SetViewpointRotationView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Set viewpoint rotation/SetViewpointRotationView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Set viewpoint rotation/SetViewpointRotationView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Set viewpoint rotation/SetViewpointRotationView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Set viewpoint rotation/SetViewpointRotationView.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Ting Chen <tchen@esri.com>
Co-authored-by: Ting Chen <tchen@esri.com>
Co-authored-by: Ting Chen <tchen@esri.com>
yo1995
previously approved these changes
May 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 Great job on your first PR! Please wait for others review.
zkline101
reviewed
Jun 1, 2022
Shared/Samples/Set viewpoint rotation/SetViewpointRotationView.swift
Outdated
Show resolved
Hide resolved
Great first PR! |
yo1995
previously approved these changes
Jun 1, 2022
mhdostal
requested changes
Jun 1, 2022
Shared/Samples/Set viewpoint rotation/SetViewpointRotationView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Set viewpoint rotation/SetViewpointRotationView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Set viewpoint rotation/SetViewpointRotationView.swift
Outdated
Show resolved
Hide resolved
philium
reviewed
Jun 1, 2022
Shared/Samples/Set viewpoint rotation/SetViewpointRotationView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Set viewpoint rotation/SetViewpointRotationView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Set viewpoint rotation/SetViewpointRotationView.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Philip Ridgeway <philip.ridgeway@gmail.com>
yo1995
previously approved these changes
Jun 2, 2022
philium
reviewed
Jun 2, 2022
philium
previously approved these changes
Jun 2, 2022
zkline101
previously approved these changes
Jun 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mhdostal
previously approved these changes
Jun 3, 2022
yo1995
approved these changes
Jun 6, 2022
mhdostal
approved these changes
Jun 6, 2022
zkline101
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Set viewpoint rotation
inMaps
category.URL to README: README URL
Linked Issue(s)
common-samples/issues/3578