Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Set viewpoint rotation #11

Merged
merged 27 commits into from
Jun 6, 2022
Merged

[New] Set viewpoint rotation #11

merged 27 commits into from
Jun 6, 2022

Conversation

clee088
Copy link
Contributor

@clee088 clee088 commented May 31, 2022

Description

This PR implements Set viewpoint rotation in Maps category.
URL to README: README URL

Linked Issue(s)

  • common-samples/issues/3578

@clee088 clee088 requested a review from yo1995 May 31, 2022 16:54
clee088 and others added 2 commits May 31, 2022 14:32
Co-authored-by: Ting Chen <tchen@esri.com>
Co-authored-by: Ting Chen <tchen@esri.com>
Co-authored-by: Ting Chen <tchen@esri.com>
@clee088 clee088 requested a review from yo1995 May 31, 2022 19:23
yo1995
yo1995 previously approved these changes May 31, 2022
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 Great job on your first PR! Please wait for others review.

@zkline101
Copy link
Contributor

Great first PR!

yo1995
yo1995 previously approved these changes Jun 1, 2022
Co-authored-by: Philip Ridgeway <philip.ridgeway@gmail.com>
yo1995
yo1995 previously approved these changes Jun 2, 2022
philium
philium previously approved these changes Jun 2, 2022
zkline101
zkline101 previously approved these changes Jun 2, 2022
Copy link
Contributor

@zkline101 zkline101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdostal
mhdostal previously approved these changes Jun 3, 2022
@clee088 clee088 dismissed stale reviews from mhdostal, zkline101, philium, and yo1995 via 7aed6ec June 6, 2022 18:07
@clee088 clee088 merged commit 678968a into v.next Jun 6, 2022
@clee088 clee088 deleted the clee/New-MapRotation branch June 6, 2022 19:15
@yo1995 yo1995 moved this from In Progress to Done in SwiftUI Sample Viewer prototyping Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants