-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Show device location with NMEA data sources #144
Conversation
# Conflicts: # Samples.xcodeproj/project.pbxproj
# Conflicts: # Samples.xcodeproj/project.pbxproj
# Conflicts: # Samples.xcodeproj/project.pbxproj
# Conflicts: # Samples.xcodeproj/project.pbxproj
# Conflicts: # Samples.xcodeproj/project.pbxproj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also merge from the latest v.next
. Here are some initial thoughts. After they are addressed, I'll add someone who's more familiar with async tasks to review.
Shared/Samples/Display device location with NMEA data sources/SimulatedNMEADataSource.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Display device location with NMEA data sources/SimulatedNMEADataSource.swift
Outdated
Show resolved
Hide resolved
...ay device location with NMEA data sources/DisplayDeviceLocationWithNMEADataSourcesView.swift
Outdated
Show resolved
Hide resolved
...ay device location with NMEA data sources/DisplayDeviceLocationWithNMEADataSourcesView.swift
Outdated
Show resolved
Hide resolved
...ice location with NMEA data sources/DisplayDeviceLocationWithNMEADataSourcesView.Model.swift
Outdated
Show resolved
Hide resolved
...ice location with NMEA data sources/DisplayDeviceLocationWithNMEADataSourcesView.Model.swift
Outdated
Show resolved
Hide resolved
...ice location with NMEA data sources/DisplayDeviceLocationWithNMEADataSourcesView.Model.swift
Outdated
Show resolved
Hide resolved
...ice location with NMEA data sources/DisplayDeviceLocationWithNMEADataSourcesView.Model.swift
Outdated
Show resolved
Hide resolved
...ice location with NMEA data sources/DisplayDeviceLocationWithNMEADataSourcesView.Model.swift
Outdated
Show resolved
Hide resolved
I'd like to hear more feedback on the detached task part of code. See the unresolved conversations. All other suggestions are applied. |
.../Show device location with NMEA data sources/ShowDeviceLocationWithNMEADataSourcesView.swift
Show resolved
Hide resolved
Shared/Samples/Show device location with NMEA data sources/README.md
Outdated
Show resolved
Hide resolved
…DME.md Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
...device location with NMEA data sources/ShowDeviceLocationWithNMEADataSourcesView.Model.swift
Outdated
Show resolved
Hide resolved
...device location with NMEA data sources/ShowDeviceLocationWithNMEADataSourcesView.Model.swift
Outdated
Show resolved
Hide resolved
.../Show device location with NMEA data sources/ShowDeviceLocationWithNMEADataSourcesView.swift
Outdated
Show resolved
Hide resolved
.../Show device location with NMEA data sources/ShowDeviceLocationWithNMEADataSourcesView.swift
Show resolved
Hide resolved
...device location with NMEA data sources/ShowDeviceLocationWithNMEADataSourcesView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show device location with NMEA data sources/FileNMEASentenceReader.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show device location with NMEA data sources/FileNMEASentenceReader.swift
Outdated
Show resolved
Hide resolved
private(set) Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
Thank everyone for the efforts to put this one together! 🥳 |
Description
This PR implements
Show device location with NMEA data sources
inMaps
category.URL to README: here
Linked Issue(s)
swift/issues/2258
To Discuss
I've taken this over from Mark since he is occupied with feature team work. I made the following changes since 5ae8e26
Task.detached
part created by Mark. Initially I thought it would be better to use a task group for this purpose, but the tasks seem to work well, so I didn't change them other than making them private. Discussion at [New] Show device location with NMEA data sources #144 (comment)Screenshots
To do before merge