-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Run valve isolation trace #203
Conversation
a1681af
to
c7a9155
Compare
This PR is now ready for review. I broke up the view model into separate files and resolved all linter warnings. |
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Enums.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Good point. The old sample does not allow the filter barriers to be reset, but that should be supported. Since there is more toolbar real estate, perhaps having two separate buttons (Trace and Reset) to run or reset the trace would support this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First batch of comments.
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/run-valve-isolation-trace-2.png
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/run-valve-isolation-trace-2.png
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for writing this sample! It's been a great effort and while there are a few things that can be improved, overall it works well!
Only 1 remaining suggestion that causes a warning in the code.
Description
This PR implements
Run valve isolation trace
in theUtility Network
category.URL to README: URL
Linked Issue(s)
swift/issues/4067
How To Test
Screenshots