-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Create buffers around points #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of comments.
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
…dPointsView.swift Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift Co-authored-by: Ting <tchen@esri.com>
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
…dPointsView.swift Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
…dPointsView.swift Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
…fersAroundPoints'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation reads well, but the style is not consistent with other samples in terms of using code voice to refer to a type. See the documentation in the other samples for reference.
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
…dPointsView.swift Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
…dPointsView.swift Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
…dPointsView.swift Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
…dPointsView.swift Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2nd batch of comments. Good work!
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
…dPointsView.swift Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift Co-authored-by: Ting <tchen@esri.com>
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
…dPointsView.swift Co-authored-by: Ting <tchen@esri.com>
Description
This PR implements
Create buffers around points
inGeometry
category.URL to README: https://github.com/Esri/arcgis-maps-sdk-swift-samples/tree/Caleb/New-CreateBuffersAroundPoints/Shared/Samples/Create%20buffers%20around%20points
Linked Issue(s)
swift/issues/4100
How To Test
Screenshots