Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Create buffers around points #185

Merged
merged 49 commits into from
Jun 6, 2023

Conversation

CalebRas
Copy link
Contributor

Description

This PR implements Create buffers around points in Geometry category.
URL to README: https://github.com/Esri/arcgis-maps-sdk-swift-samples/tree/Caleb/New-CreateBuffersAroundPoints/Shared/Samples/Create%20buffers%20around%20points

Linked Issue(s)

  • swift/issues/4100

How To Test

  • Tap outside the boundary to see "Tap with the boundary to add buffer" message at the top.
  • Tap inside the boundary to add a point.
  • Enter a value, such as 100.
  • Tap done. (See "Buffer created." message)
  • Add another buffer close enough to the first that they will overlap.
  • Toggle "Union" on and off to see the buffers merge and un-merge.
  • Tap "Clear" to remove all the buffers and points from the map. (See "Tap on the map to add buffers" message.)

Screenshots

create-buffers-around-points

@CalebRas CalebRas requested a review from yo1995 May 26, 2023 15:27
@CalebRas CalebRas self-assigned this May 26, 2023
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of comments.

CalebRas and others added 7 commits May 31, 2023 10:06
…dPointsView.swift

Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift

Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift

Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift

Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift

Co-authored-by: Ting <tchen@esri.com>
@CalebRas CalebRas requested a review from yo1995 May 31, 2023 17:19
@yo1995 yo1995 requested a review from des12437 May 31, 2023 18:29
CalebRas and others added 4 commits May 31, 2023 16:22
…dPointsView.swift

Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
…dPointsView.swift

Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
Copy link
Contributor

@des12437 des12437 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation reads well, but the style is not consistent with other samples in terms of using code voice to refer to a type. See the documentation in the other samples for reference.

…dPointsView.swift

Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
CalebRas and others added 3 commits June 2, 2023 13:42
…dPointsView.swift

Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
…dPointsView.swift

Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
…dPointsView.swift

Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
des12437
des12437 previously approved these changes Jun 2, 2023
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2nd batch of comments. Good work!

…dPointsView.swift

Co-authored-by: Ting <tchen@esri.com>
CalebRas and others added 9 commits June 5, 2023 13:54
…dPointsView.swift

Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift

Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift

Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift

Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift

Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift

Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift

Co-authored-by: Ting <tchen@esri.com>
…dPointsView.swift

Co-authored-by: Ting <tchen@esri.com>
@CalebRas CalebRas requested a review from yo1995 June 5, 2023 21:45
…dPointsView.swift

Co-authored-by: Ting <tchen@esri.com>
@CalebRas CalebRas requested a review from yo1995 June 5, 2023 23:08
@CalebRas CalebRas merged commit 008e246 into v.next Jun 6, 2023
1 check passed
@CalebRas CalebRas deleted the Caleb/New-CreateBuffersAroundPoints branch June 6, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants