[Update] Refactor CreateBuffersAroundPointsView.Model
#213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
des12437
reviewed
Jun 27, 2023
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Show resolved
Hide resolved
des12437
previously approved these changes
Jun 27, 2023
philium
reviewed
Jun 27, 2023
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Show resolved
Hide resolved
philium
reviewed
Jun 27, 2023
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
des12437
previously approved these changes
Jun 28, 2023
pgruenler
reviewed
Jul 18, 2023
Shared/Samples/Create buffers around points/CreateBuffersAroundPointsView.swift
Outdated
Show resolved
Hide resolved
pgruenler
previously approved these changes
Jul 18, 2023
…dPointsView.swift Co-authored-by: Phil Gruenler <pgruenler@esri.com>
pgruenler
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #212. This PR updates
Create buffers around pointsadded in #185 .Linked Issue(s)
How To Test
The sample should behave the same as before.
To Discuss
In hindsight I should have paid more attention to the code review. This sample was one of Caleb's first samples so I let it go without being too harsh.
Ideally we should have a more careful mindset on how to use the data model object. Try to avoid the case where the model knows about states in the UI, or in other words, UI states should be derived from the model, not reverse.