[Update] Sample Viewer category front page

[CalebRas]

Description

This PR updates the front page of the sample viewer to organize the samples into categories, similar to the old iOS Sample Viewer. The new common design categories were used. All of the currently implemented samples fall under one of the sample categories.

Linked Issue(s)

• swift/issues/4229

How To Test

• Load the sample viewer.
• Tap on a category to navigate to a list of samples in that category.
• Tap on the search bar to search for a sample.

Screenshots

Before	After

To Discuss

• There is a bug where the navigation title at the top of the samples list jumps after tapping on a category and the list first loads.
• There is a bug when you back out of a sample after you entered it through a category. It then loads to the category view instead of the samples list view and it no longer lets you in that specific category.

[yo1995]

I'm not particularly good at naming views, so let's discuss that with other reviewers in the next step.

First batch of comments.

[yo1995]

LGTM

[yo1995]

I added David to the reviewers as he is familiar with UI best practices.

[yo1995]

There is a bug when you back out of a sample after you entered it through a category. It then loads to the category view instead of the samples list view and it no longer lets you in that specific category.

I read the code and couldn't find anything that might caused this bug, except the difference between iOS 16 NavigationSplitView and iOS 15 NavigationView. I also tested on iOS 15.5 and the bug is not there 🤔 . @philium If you have a chance can you help take a look at CategoryGridView and see if anything stands out? Thank you.

[des12437]

Looks good. I'm not sure if the AboutView is within the scope of this PR, but noticed that the logo and copyright text could use some spacing.

The copyright year can also be generated rather than hardcoded:

Text("Copyright © 2022 - \(String(Calendar.current.component(.year, from: Date()))) Esri. All Rights Reserved.")

[CalebRas]

Looks good. I'm not sure if the AboutView is within the scope of this PR, but noticed that the logo and copyright text could use some spacing.

The copyright year can also be generated rather than hardcoded:

Text("Copyright © 2022 - \(String(Calendar.current.component(.year, from: Date()))) Esri. All Rights Reserved.")

Yea I think this would fall under another issue/PR.

[yo1995]

Please see Phil's comment on the second part of the year string: #3 (comment) It shouldn't be dynamic, but rather manually updated to reflect the last change to the code.

[yo1995]

Sorry, I meant to hold this PR from being merged until the navigation bug (mentioned in the "To Discuss" section in the description) is addressed. I'll let Phil to comment on that.

@dfeinzimer and @des12437 do you have thought on that?

[dfeinzimer]

@dfeinzimer and @des12437 do you have thought on that?

Hm, sorry I missed those in the description!

Neither of them seem to still be present? Am I missing? No jumping spotted and I'm able to re-open the Analysis category.

That's unless you mean the jumping the second time around when coming back into the Analysis category?

[yo1995]

@dfeinzimer That's intriguing behavior! 😂 May I ask which Xcode and Sim version are you using? It differs from mine both on iOS 15 and 16…

That's unless you mean the jumping the second time around when coming back into the Analysis category?

When you tap "Back" from a sample, it directly jump back to the category grid view, which means sth's wrong with the navigation stack. 🤔

[dfeinzimer]

May I ask which Xcode and Sim version are you using? It differs from mine both on iOS 15 and 16…

Xcode 14.3.1 with a 14 Pro Max sim on iOS 17.0

[des12437]

@dfeinzimer and @des12437 do you have thought on that?

I see the same navigation issue on Xcode 14.3.1 and iPhone 14 Pro Max simulator iOS 16.4.