Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Issue with sidebar navigation #227

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

philium
Copy link
Contributor

@philium philium commented Jul 20, 2023

Fixes issue described here, where going back from a sample takes the user all the way back to the Categories view, not the view for the category to which the sample belongs. This also means that when the categories are displayed in a sidebar, tapping on a category opens that category in the sidebar, which is expected behavior for this kind of a navigation setup on iOS.

Fixes issue described [here](#221 (comment)), where going back from a sample takes the user all the way back to the Categories view, not the view for the category to which the sample belongs. This also means that when the categories are displayed in a sidebar, tapping on a category opens that category in the sidebar, which is expected behavior for this kind of a navigation setup on iOS.
@yo1995 yo1995 changed the title Fix issue with sidebar navigation [Fix] Issue with sidebar navigation Jul 20, 2023
@yo1995
Copy link
Collaborator

yo1995 commented Jul 20, 2023

@CalebRas Can you double check if this is the expected behavior on all iOS 16+ targets? Thanks.

I noticed that on Mac Catalyst, the back button is placed on the detail view rather than the sidebar, and I think that is expected.

@CalebRas
Copy link
Contributor

@CalebRas Can you double check if this is the expected behavior on all iOS 16+ targets? Thanks.

The bugs I was originally experiencing are both gone. Now, there is a new bug where the navigation tile jumps from inline to large when backing out of a sample.

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-07-20.at.10.35.22.mp4

@yo1995
Copy link
Collaborator

yo1995 commented Jul 20, 2023

Now, there is a new bug where the navigation tile jumps from inline to large when backing out of a sample.

That might be sth we have no control, unfortunately 😥 . The same code behaves correctly on iOS 17 beta, so I guess it is an iOS/SwiftUI bug.

nav.mp4

@philium
Copy link
Contributor Author

philium commented Jul 20, 2023

Now, there is a new bug where the navigation tile jumps from inline to large when backing out of a sample.

That bug was reproducible before the category changes went in. I noticed it the other day.

Copy link
Contributor

@dfeinzimer dfeinzimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely across all platforms

@philium philium merged commit 9ac2e62 into v.next Jul 20, 2023
1 check passed
@philium philium deleted the philium/fix-issue-with-sidebar-navigation branch July 20, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants