[Update] Floating Panel usage #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yo1995 will this need a 2nd reviewer? |
|
I'll add Zach to take a look |
yo1995
previously approved these changes
Aug 15, 2023
...ts using clustering feature reduction/DisplayPointsUsingClusteringFeatureReductionView.swift
Outdated
Show resolved
Hide resolved
...ts using clustering feature reduction/DisplayPointsUsingClusteringFeatureReductionView.swift
Outdated
Show resolved
Hide resolved
zkline101
reviewed
Aug 15, 2023
...ts using clustering feature reduction/DisplayPointsUsingClusteringFeatureReductionView.swift
Show resolved
Hide resolved
zkline101
previously approved these changes
Aug 15, 2023
This reverts commit 70b3e3d.
zkline101
previously approved these changes
Aug 16, 2023
yo1995
previously approved these changes
Aug 16, 2023
|
Updated to Nimesh's proposed fix, ready for re-review |
zkline101
approved these changes
Aug 18, 2023
yo1995
approved these changes
Aug 18, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates usage of the Floating Panel across three samples in response to changes in Toolkit #404
How To Test
Test the 3 changed samples on Catalyst, iPhone and iPad.