-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release] Merge 200.2 samples into main
#266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ting <tchen@esri.com>
This reverts commit 70b3e3d.
On iOS, the temporary directory should always be within the same data container and volume where we create the subdirectory. On macOS, it's almost sure that the data container volume will have a system temporary directory. See #251 for details.
[Fix] Temporary directory creation
…dynamic-entity-layer-sample [Fix] Add dynamic entity layer settings presentation refactor
[Update] Allow bundle resources on Mac Catalyst
[New] Filter features in scene
…ne-sample [Fix] Filter features in scene
[Fix] "false" utility network load problem
[Update] Adjust info view control size
…entity-layer-sample [Update] Improve visibility of dynamic entities in sample
…ea-feedback [Update] Download preplanned map area feedback
yo1995
requested review from
saratchandrakarumuri,
a team,
rolson,
zkline101 and
dg0yal
and removed request for
a team and
rolson
September 11, 2023 19:43
dg0yal
approved these changes
Sep 11, 2023
saratchandrakarumuri
approved these changes
Sep 11, 2023
zkline101
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works good. I see a few sendable warnings but I bet you are already aware of those :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR merges all 200.2 samples into
main
branch.How To Test
Open and build the Samples project on
v.next
. No unexpected warnings or crashes.