Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Update] Refactor DownloadVectorTilesToLocalCacheView #325

Merged
merged 4 commits into from
Dec 21, 2023
Merged

[Update] Refactor DownloadVectorTilesToLocalCacheView #325

merged 4 commits into from
Dec 21, 2023

Conversation

yo1995
Copy link
Collaborator

@yo1995 yo1995 commented Dec 19, 2023

Description

This PR refactors DownloadVectorTilesToLocalCacheView. Close #114

Linked Issue(s)

How To Test

  • Run the sample and ensure the vector tiles download still works.
  • Use Network Link Conditioner or other ways to emulate these scenarios
    • The basemap loads too slowly, so the exportVectorTilesTask is nil
    • The exportVectorTilesTask loads too slowly, so its load status is not loaded
    • In both cases, the download button should be disabled
  • When reviewing code, you can hide whitespaces to simplify the review process

@yo1995 yo1995 self-assigned this Dec 19, 2023
@yo1995 yo1995 requested review from a team, njarecha and CalebRas and removed request for a team December 19, 2023 23:00
@yo1995 yo1995 linked an issue Dec 19, 2023 that may be closed by this pull request
Fix the download conditional logic in DownloadVectorTilesToLocalCacheView #114
Closed
@yo1995 yo1995 requested a review from CalebRas December 20, 2023 00:26
CalebRas
CalebRas approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@CalebRas CalebRas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

njarecha
njarecha approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@njarecha njarecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@yo1995 yo1995 merged commit d7c4685 into v.next Dec 21, 2023
1 check passed
@yo1995 yo1995 deleted the Ting/Update-DownloadVectorTilesToLocalCacheView branch December 21, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njarecha njarecha njarecha approved these changes

@CalebRas CalebRas CalebRas approved these changes

Assignees

@yo1995 yo1995

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the download conditional logic in DownloadVectorTilesToLocalCacheView
3 participants
@yo1995 @njarecha @CalebRas