[Update] Use model to manage geo view and data #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove wrong pattern in the view model where it affects the view.
dfeinzimer
reviewed
Jan 28, 2023
There was a problem hiding this comment.
Good to go from my perspective after this open discussion has some resolution.
yo1995
requested review from
philium and
dfeinzimer
and removed request for
philium
dfeinzimer
previously approved these changes
Jan 31, 2023
dfeinzimer
previously approved these changes
Feb 1, 2023
philium
previously approved these changes
Feb 7, 2023
Shared/Samples/Add raster from file/AddRasterFromFileView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Download vector tiles to local cache/DownloadVectorTilesToLocalCacheView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show result of spatial operations/ShowResultOfSpatialOperationsView.swift
Outdated
Show resolved
Hide resolved
Add guarding conditions to avoid unexpected outcomes. Co-authored-by: Philip Ridgeway <philip.ridgeway@gmail.com>
philium
approved these changes
Feb 7, 2023
dfeinzimer
approved these changes
Feb 7, 2023
|
Thanks for the suggestions. I'll fix other issues in the upcoming PRs. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the
@StateObjectpattern in most of the samples, to use an observable model object to manage the data.Linked Issue(s)
swift/issues/3271swift/issues/3250Add raster from file#48 and [Fix] Raster file load issue #89How To Test
To run the app, you'll need to
.package(name: "arcgis-maps-sdk-swift", path: "../swift/ArcGIS").No behavioral change should present. Verify all changed sample to work as expected.
To Discuss