docs: new conceptual guide to introduce the lib #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISSUES CLOSED: #318
tomwayson
approved these changes
Jan 7, 2019
| getUser(`jgravois`) | ||
| .then(response) // { firstName: "john", description: "open source geodev" ... } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Maybe add "vs:" here, or comments to the top of each code block - something to indicate that the first block is rest-js and the second is vanilla JS.
| // construct the url yourself and don't forget to tack on f=json | ||
| const url = "https://www.arcgis.com/sharing/rest/community/users/jgravois?f=json"; | ||
|
|
||
| var xhr = new XMLHttpRequest(); |
There was a problem hiding this comment.
ha! it's kind of cheating to compare to XMLHttpRequest() instead of fetch(), but I'm impressed that you pulled that out of the old archives!
docs/src/guides/package-overview.md
Outdated
| * `200` responses that contain an error are trapped for | ||
| * the generic `f=json` parameter is appended | ||
|
|
||
| And we haven't even begun to discuss [authentication](../node/). |
There was a problem hiding this comment.
seems like ../browser-authentication/ is a better link here than ../node/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUES CLOSED: #318