Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support customizing portal when instantiating ApplicationSession #428

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Support customizing portal when instantiating ApplicationSession #428

merged 1 commit into from
Jan 9, 2019

Conversation

alukach
Copy link
Contributor

@alukach alukach commented Jan 8, 2019

Thoughts on allowing a developer to include their portal address when creating an ApplicationSession? I find doing the following to be somewhat unintuitive:

const session = new ApplicationSession({
  clientId: "abc",
  clientSecret: "123"
});
session.portal = 'https://myPortal/arcgis/sharing'

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3ffdddb on alukach:patch-3 into b84bad2 on Esri:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3ffdddb on alukach:patch-3 into b84bad2 on Esri:master.

tomwayson
tomwayson approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@tomwayson tomwayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

jgravois
jgravois approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@jgravois jgravois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL: ArcGIS Enterprise supports /registerApp too.

thx for the contribution @alukach!

@jgravois jgravois merged commit 5decc7e into Esri:master Jan 9, 2019
@jgravois jgravois mentioned this pull request Jan 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomwayson tomwayson tomwayson approved these changes

@jgravois jgravois jgravois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alukach @coveralls @tomwayson @jgravois