fix(oauth): check for window parent correctly in oauth without popup #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
window.parent is equal to itself when there is no parent, so it will always be truthy. Need to check that the window has a separate parent instead. AFFECTS PACKAGES: @esri/arcgis-rest-auth
2 similar comments
jgravois
approved these changes
Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window.parent is equal to itself when there is no parent (see https://developer.mozilla.org/en-US/docs/Web/API/Window/parent), so it will always be truthy. Need to check
that the window has a separate parent instead.
Currently, if you set
popupto false when doing oauth through the UserSession, you'll get an error when callingcompleteOauth2because it tries to runat UserSession:342
AFFECTS PACKAGES:
@esri/arcgis-rest-auth