Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Update bitcode settings #1197

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Update bitcode settings #1197

merged 2 commits into from
Aug 16, 2022

Conversation

vquach2404
Copy link
Collaborator

This PR addresses the build errors with Xcode 14. See cocoa/issues/11193 for more info.

@vquach2404 vquach2404 marked this pull request as ready for review August 12, 2022 21:27
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fully aware of the impact of this change - seems to be required by Xcode 14.
But it is the only change we need to make in the project file - that is what I approve here. 😅

Edit: I also suggest marking this PR as draft, as we are not including it in the upcoming release next week, building with Xcode 13.

Edit again: with the latest change to default setting, we can merge it now.

@philium
Copy link
Contributor

philium commented Aug 12, 2022

A couple questions:

  1. Did you try using the default value (select the setting and press the Delete key)?
  2. Did you try uploading a build to App Store Connect after making these changes?

Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pressing delete to go to default value will remove the entries in the project file.

@philium
Copy link
Contributor

philium commented Aug 12, 2022

shows like this in Xcode UI

@yo1995 Is that in Xcode 13 or 14? With that change, I'm hoping they'll be different, with Xcode 13 being Yes and Xcode 14 being No.

@yo1995
Copy link
Collaborator

yo1995 commented Aug 12, 2022

Is that in Xcode 13 or 14? With that change, I'm hoping they'll be different, with Xcode 13 being Yes and Xcode 14 being No.

That is verified. The screenshot above was Xcode 13. See the comparison below by resetting the bitcode config to default.

Xcode 13 Xcode 14
image image

@vquach2404
Copy link
Collaborator Author

vquach2404 commented Aug 12, 2022

  1. Did you try uploading a build to App Store Connect after making these changes?

@philium To answer your other question, I ran into no errors with bitcode set to "No" (Xcode 13.4) while uploading a build to AppStore Connect.

Co-authored-by: Ting Chen <tchen@esri.com>
@vquach2404 vquach2404 requested a review from yo1995 August 12, 2022 22:48
@dg0yal
Copy link
Member

dg0yal commented Aug 16, 2022

Edit: I also suggest marking this PR as draft, as we are not including it in the upcoming release next week, building with Xcode 13.

This change should not hurt Xcode 13
We should get this into the U15 release so that when users upgrade to xcode 14 in the fall things will continue to work

@yo1995 yo1995 marked this pull request as ready for review August 16, 2022 15:47
@yo1995 yo1995 requested a review from dg0yal August 16, 2022 15:48
@vquach2404 vquach2404 merged commit 55616dc into v.next Aug 16, 2022
@vquach2404 vquach2404 deleted the Viv/updateBitcode branch August 16, 2022 17:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants