-
Notifications
You must be signed in to change notification settings - Fork 396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fully aware of the impact of this change - seems to be required by Xcode 14.
But it is the only change we need to make in the project file - that is what I approve here. 😅
Edit: I also suggest marking this PR as draft, as we are not including it in the upcoming release next week, building with Xcode 13.
Edit again: with the latest change to default setting, we can merge it now.
A couple questions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pressing delete to go to default value will remove the entries in the project file.
@yo1995 Is that in Xcode 13 or 14? With that change, I'm hoping they'll be different, with Xcode 13 being Yes and Xcode 14 being No. |
@philium To answer your other question, I ran into no errors with bitcode set to "No" (Xcode 13.4) while uploading a build to AppStore Connect. |
Co-authored-by: Ting Chen <tchen@esri.com>
This change should not hurt Xcode 13 |
This PR addresses the build errors with Xcode 14. See
cocoa/issues/11193
for more info.