This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
Identify KML Features sample #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the Identify KML Features sample.
|
The popup font size seems too small, at least in the simulator. Is this set by the data source?
|
|
@qsmmorgan Unfortunately the font size is embedded in the html: <font size="+1"><b>Flash Flooding is possible</b> in the enclosed area during Wed, Sep 19, 2018.</font>I don't know if there's a way to modify that. |
|
@philium One option to consider is converting the HTML to func showCallout(for placemark: AGSKMLPlacemark, at point: AGSPoint) {
let contentData = placemark.balloonContent.data(using: .utf8)!
let attributedText = try? NSMutableAttributedString(data: contentData, options: [.documentType: NSAttributedString.DocumentType.html], documentAttributes: nil)
let textView = UITextView(frame: CGRect(origin: .zero, size: CGSize(width: 320, height: 100)))
textView.attributedText = attributedText
textView.backgroundColor = placemark.balloonBackgroundColor
mapView.callout.customView = textView
mapView.callout.show(at: point, screenOffset: .zero, rotateOffsetWithMap: false, animated: true)
}This makes the font size slightly larger by default and lets the developer customize the text any way they like. It also makes the callouts native without the web view overhead.
|
|
Stack Trace |
qsmmorgan
suggested changes
Oct 1, 2018
There was a problem hiding this comment.
Note on the image: it would be nice to show the map with actual data and a callout, but not many people see the image anyway.
Looks good overall! I added some minor feedback. The only thing I really think needs to be addressed somehow is the callout text size I mentioned earlier.
arcgis-ios-sdk-samplesTests/Sample Tests/IdentifyKMLFeaturesViewControllerTests.swift
Show resolved
Hide resolved
arcgis-ios-sdk-samples/Layers/Identify KML features/IdentifyKMLFeaturesViewController.swift
Show resolved
Hide resolved
arcgis-ios-sdk-samples/Layers/Identify KML features/IdentifyKMLFeaturesViewController.swift
Show resolved
Hide resolved
arcgis-ios-sdk-samples/Layers/Identify KML features/IdentifyKMLFeaturesViewController.swift
Outdated
Show resolved
Hide resolved
saratchandrakarumuri
previously approved these changes
Oct 1, 2018
There was a problem hiding this comment.
Other than the comments made by @qsmmorgan regarding the image and the text size in the callout, sample is looking good and working as expected
@qsmmorgan I agree that it would be nice to show the callout. Unfortunately there were no weather events when I took the screenshot. I'll try again. |
philium
added a commit
to Esri/arcgis-runtime-samples-macos
that referenced
this pull request
Oct 3, 2018
Adds the Identify KML Features sample. Corresponding iOS PR: Esri/arcgis-runtime-samples-ios#498
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Identify KML Features sample.