Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added border colors #43

Merged
merged 4 commits into from
Dec 6, 2019
Merged

Added border colors #43

merged 4 commits into from
Dec 6, 2019

Conversation

julio8a
Copy link
Contributor

@julio8a julio8a commented Dec 5, 2019 •
edited
Loading

  • Changed pressed to press
  • added border values: border 1, 2, 3, hover, press

julio8a pushed a commit to Esri/calcite-design-system that referenced this pull request Dec 5, 2019
changes CSS var values to SASS vars from calcite-color
48436c3 
Still missing the border SASS vars from calcite-colors. Waiting for [#43](Esri/calcite-colors#43) to finishing adding the border SASS variables.
macandcheese
macandcheese approved these changes Dec 6, 2019
View reviewed changes
Copy link

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to add a "breaking change" section to the changelog and doc what was changed there.

@julio8a julio8a merged commit c36215f into master Dec 6, 2019
@driskull driskull deleted the added-border-colors branch October 7, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macandcheese macandcheese macandcheese approved these changes

@paulcpederson paulcpederson Awaiting requested review from paulcpederson

@bstifle bstifle Awaiting requested review from bstifle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julio8a @macandcheese