Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Configurable slider highlighting #1631

Closed
bpatterson88 opened this issue Feb 26, 2021 · 29 comments
Closed

Enhancement: Configurable slider highlighting #1631

bpatterson88 opened this issue Feb 26, 2021 · 29 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. c-slider Issues that pertain to the calcite-slider component design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.

Comments

@bpatterson88
Copy link
Contributor

bpatterson88 commented Feb 26, 2021

Description

Allow slider to highlight different sections of the rail, ex. left of the handle or right of the handle.

Acceptance Criteria

  • Single value: rail can highlight right, left, or none

Relevant Info

Dashboards currently uses sliders to filter visualizations, and depending on the operator we highlight different parts of the rail. This request will give Calcite parity with the current Dashboards implementation of slider.

Which Component

Slider

Example Use Case

  • Select all values greater than N (ex. to the right of the handle)
  • Select N (ex. no highlighting)
@bpatterson88 bpatterson88 added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. labels Feb 26, 2021
@paulcpederson
Copy link
Member

@bpatterson88 would this need to apply to range as well or just single value?

@bpatterson88
Copy link
Contributor Author

@paulcpederson Nope, just the single value.

Also, updated the request to include a 'none' option for highlighting, where the slider is used to select a single value.

@benelan benelan added the needs triage Planning workflow - pending design/dev review. label Sep 27, 2021
@benelan
Copy link
Member

benelan commented Oct 13, 2021

Hi @bpatterson88, is this still valid? If so can you please provide a use case example?

@bpatterson88
Copy link
Contributor Author

@benelan Dashboards uses sliders for less than, greater than, and equals queries. Different parts of the slider rail are highlighted depending on the operator. The screenshots below show our current implementation.

Screen Shot 2021-11-29 at 4 30 29 PM
Screen Shot 2021-11-29 at 4 30 38 PM
Screen Shot 2021-11-29 at 4 30 47 PM

@ellenupp
Copy link

Hi @benelan, just wanted to put this issue on your radar again and see where it's at. We would love to start using calcite-slider in dashboards but this is a blocker for us.

@benelan
Copy link
Member

benelan commented Oct 11, 2022

@bpatterson88 thanks for providing the use case, and thanks for bumping the issue @ellenupp. We are planning to get this in before v1 and will have a better timeline after our next triage meeting, to determine which upcoming sprint has cycles.

@richiecarmichael
Copy link

This is needed for the new JSAPI Range Slider (see #46032).

@ubatsukh
Copy link

@driskull as we discussed yesterday this is a high priority issue for us! MV needs Range Slider for multidimensional image services and the API implementation cannot proceed until the calcite slider has support for this.

@driskull driskull added the p - high Issue should be addressed in the current milestone, impacts component or core functionality label Nov 30, 2022
@ellenupp
Copy link

Hello, any updates on this issue? We still need this for Dashboards.

@geospatialem geospatialem added ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. labels May 23, 2023
@ashetland
Copy link

ashetland commented May 24, 2023

@jcfranco Thoughts on this? Some possible prop names:

highlight = none | greater-than | less-than
or
active-track = none | greater-than | less-than

active-track feels the most correct, but not sure if we already have a convention for this one.

cc @SkyeSeitz

@jcfranco
Copy link
Member

I like highlight since it's both expressive and concise. range-highlight is too verbose, right? 😛

@SkyeSeitz
Copy link

SkyeSeitz commented May 24, 2023

It sounds like these would all still fall under the single value slider- correct? if so, I think the range-highlight prop name might confuse the distinction.
image

@SkyeSeitz
Copy link

One other note to confirm- this would mean all current single value sliders would change in appearance from the left design with a highlighted track to the right design with no highlight?
image

@ashetland
Copy link

Based on our discussion, yes it would seem that this would make the default highlight=none which might be considered a breaking change for folks.

And yes, just to confirm, this would only apply to the single slider, not range, per the comments above.

@jcfranco
Copy link
Member

It sounds like these would all still fall under the single value slider- correct? if so, I think the range-highlight prop name might confuse the distinction.

Good point. I wasn't considering the range mode. How would highlight options interact with this mode?

this would mean all current single value sliders would change in appearance from the left design with a highlighted track to the right design with no highlight?
Based on our discussion, yes it would seem that this would make the default highlight=none which might be considered a breaking change for folks.

Is this because the proposed default would be "none" or is there another reason? Wondering if we could make less-than the default to minimize visual differences.

@SkyeSeitz SkyeSeitz added the design Issues that need design consultation prior to development. label May 25, 2023
@SkyeSeitz
Copy link

SkyeSeitz commented May 25, 2023

Stepping back and evaluating the greater than/less than use case, it ultimately functions more as a range with a fixed start or end because it is outputting everything between two values. Adding something along the lines of a fixed-start/end prop as a range enhancement would avoid confusion and unwanted overrides to current default Sliders - changing them to a less than function or changing their appearance to no highlight.

I have mapped out that story below (design details for fixed-start/end could use work), but would be good to get confirmation from Dashboards on their use case first.

image

@ellenupp
Copy link

Thanks for the quick work on this!

We also have a use for range sliders but we only ever want to highlight between the two handles in that case. So this enhancement would just be for the single value case, when we want to highlight either the left/right/neither side of the track depending on the operation the value is used in.

Something like highlight = none | greater-than | less-than where this only has an effect when there's a single value would do the trick.

changing them to a less than function

I'm just envisioning this to be a visual representation, no change to the actual value or function of the slider.

jcfranco added a commit that referenced this issue Apr 25, 2024
**Related Issue:** #1631

## Summary

This fixes an issue where ticks outside of the active fill were
highlighted.

**Note**: this depends on #9195
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Apr 25, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Apr 25, 2024
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Apr 26, 2024

Verified on 2.8.0-next.12

image

@DitwanP DitwanP closed this as completed Apr 26, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. 2 - in development Issues that are actively being worked on. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. 4 - verified Issues that have been released and confirmed resolved. labels Apr 26, 2024
@DitwanP DitwanP assigned jcfranco and unassigned geospatialem and DitwanP Apr 26, 2024
@DitwanP DitwanP reopened this Apr 26, 2024
jcfranco added a commit that referenced this issue Apr 26, 2024
**Related Issue:** #1631

## Summary

This ensures ranged sliders place the fill and style ticks within the
range.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Apr 26, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Apr 26, 2024
Copy link
Contributor

Installed and assigned for verification.

@jcfranco
Copy link
Member

Installed! That should be the last of it. 🤞 #famouslastwords

Thanks everyone and sorry for the hassle!

@DitwanP
Copy link
Contributor

DitwanP commented Apr 26, 2024

😬🤞 Verified on 2.8.0-next.14

@DitwanP DitwanP closed this as completed Apr 26, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. c-slider Issues that pertain to the calcite-slider component design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Projects
None yet
Development

No branches or pull requests