Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action-bar messageOverride props correspond to both text and label #5539

Closed
geospatialem opened this issue Oct 21, 2022 · 6 comments
Closed
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. Calcite (dev) Issues logged by Calcite developers. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library spike complete Issues that have a research spike completed and dev work can proceed

Comments

@geospatialem
Copy link
Member

Summary

We presently support assistive technology (AT) users with the action-bar component for the collapse/expand buttons.

However, the support also provides the same context visually updating the text, which in some use cases doesn't provide a good interface, or user experience for visual users.

screenshot of the action bar menu with updated intlCollapse prop

Could we support both AT and visual users in providing opportunities to support both use cases?

Actual Behavior

When setting the intlCollapse property the visual text and label contain the value.

Expected Behavior

Developers should be able to specify different values for the action-bar collapse button with the displayed text (perhaps new props, textCollapse/textExpand versus what is read by AT intlCollapse/intlExpand)?

For instance, visual users may only need displayed text of "Collapse", whereas additional context is needed to support AT users, such as "Collapse accordion sample menu bar".

Reproduction Sample

https://codepen.io/geospatialem/pen/Jjvgrqv

Reproduction Steps

  1. Open the sample
  2. Observe when supplied with the intlCollapse prop the "Collapse" text is replaced with the value (e.g., "Collapse accordion sample menu bar").

Reproduction Version

beta.95

Working W3C Example/Tutorial

No response

Relevant Info

There may still be a use case for allowing the developer to change the visual text, so perhaps a new property should be introduced to account for both the accessible label (intlCollapse/intlExpand and text (perhaps textCollapse/textExpand)?

Additional background:

  • A sample with a native button that is supplied with different visual text and an accessible label for context.
  • Many other CC have similar options, such as Loader where label and text properties co-exist on the component.

Regression?

No response

Esri team

Calcite (dev)

@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. a11y Issues related to Accessibility fixes or improvements. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. p - medium Issue is non core or affecting less that 60% of people using the library labels Oct 21, 2022
@github-actions github-actions bot added the Calcite (dev) Issues logged by Calcite developers. label Oct 21, 2022
@geospatialem geospatialem reopened this Feb 6, 2023
@geospatialem geospatialem changed the title action-bar intl-collapse and intl-expand props correspond to both text and label action-bar messageOverride props correspond to both text and label Feb 6, 2023
@geospatialem geospatialem added enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. and removed bug Bug reports for broken functionality. Issues should include a reproduction of the bug. labels Feb 6, 2023
@geospatialem geospatialem added the spike Issues that cannot be estimated well enough until the team has done further research label Dec 18, 2023
@geospatialem
Copy link
Member Author

Spike to determine if this is still an issue that we should address with the 1.x and 2.x releases.

@geospatialem geospatialem self-assigned this Dec 18, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Dec 18, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Dec 18, 2023
@geospatialem
Copy link
Member Author

This is still valid, updated the Codepen to 2.0.0 to reflect the different properties and attributes.

Currently if the messageOverrides property is overwritten context is provided to AT, but the text in the component is also altered, which may not support a good user experience.

image

@geospatialem geospatialem added the spike complete Issues that have a research spike completed and dev work can proceed label Dec 19, 2023
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed spike Issues that cannot be estimated well enough until the team has done further research 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 19, 2023
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 10, 2024
@driskull driskull self-assigned this Jun 3, 2024
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned driskull Jun 3, 2024
driskull added a commit that referenced this issue Jun 6, 2024
…ssages (#9497)

**Related Issue:** #5539

## Summary

-  add expandLabel and collapseLabel to messages
@driskull
Copy link
Member

driskull commented Jun 6, 2024

This one was already marked as installed but it is installed now.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 7, 2024
@geospatialem
Copy link
Member Author

Verified in JAWS and NVDA with https://codepen.io/geospatialem/pen/Jjvgrqv in 2.10.0-next.1 with the following messageOverrides of expandLabel and collapseLabel:

document.querySelector("calcite-action-bar").messageOverrides = {
  expandLabel: "Expand accordion sample menu bar",
  collapseLabel: "Collapse accordion sample menu bar"
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. Calcite (dev) Issues logged by Calcite developers. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library spike complete Issues that have a research spike completed and dev work can proceed
Projects
None yet
Development

No branches or pull requests

4 participants