-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
action-bar messageOverride
props correspond to both text and label
#5539
Comments
intl-collapse
and intl-expand
props correspond to both text and labelmessageOverride
props correspond to both text and label
Spike to determine if this is still an issue that we should address with the 1.x and 2.x releases. |
This is still valid, updated the Codepen to 2.0.0 to reflect the different properties and attributes. Currently if the |
Installed and assigned for verification. |
This one was already marked as installed but it is installed now. |
Verified in JAWS and NVDA with https://codepen.io/geospatialem/pen/Jjvgrqv in document.querySelector("calcite-action-bar").messageOverrides = {
expandLabel: "Expand accordion sample menu bar",
collapseLabel: "Collapse accordion sample menu bar"
}; |
Summary
We presently support assistive technology (AT) users with the
action-bar
component for the collapse/expand buttons.However, the support also provides the same context visually updating the text, which in some use cases doesn't provide a good interface, or user experience for visual users.
Could we support both AT and visual users in providing opportunities to support both use cases?
Actual Behavior
When setting the
intlCollapse
property the visual text and label contain the value.Expected Behavior
Developers should be able to specify different values for the
action-bar
collapse button with the displayed text (perhaps new props,textCollapse
/textExpand
versus what is read by ATintlCollapse
/intlExpand
)?For instance, visual users may only need displayed text of "Collapse", whereas additional context is needed to support AT users, such as "Collapse accordion sample menu bar".
Reproduction Sample
https://codepen.io/geospatialem/pen/Jjvgrqv
Reproduction Steps
intlCollapse
prop the "Collapse" text is replaced with the value (e.g., "Collapse accordion sample menu bar").Reproduction Version
beta.95
Working W3C Example/Tutorial
No response
Relevant Info
There may still be a use case for allowing the developer to change the visual text, so perhaps a new property should be introduced to account for both the accessible label (
intlCollapse
/intlExpand
and text (perhapstextCollapse
/textExpand
)?Additional background:
label
andtext
properties co-exist on the component.Regression?
No response
Esri team
Calcite (dev)
The text was updated successfully, but these errors were encountered: