Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action-bar, action-pad): add expandLabel and collapseLabel to messages #9497

Merged
merged 5 commits into from
Jun 6, 2024

Conversation

driskull
Copy link
Member

@driskull driskull commented Jun 3, 2024

Related Issue: #5539

Summary

  • add expandLabel and collapseLabel to messages

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Jun 3, 2024
@driskull driskull changed the title feat(action-bar): add expandLabel and collapseLabel to messages feat(action-bar, action-pad): add expandLabel and collapseLabel to messages Jun 3, 2024
@driskull driskull marked this pull request as ready for review June 3, 2024 18:57
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Before merging, can you add a test that asserts on the label/text separation? This will probably need to override messages since they're the same text.

@driskull driskull added the skip visual snapshots Pull requests that do not need visual regression testing. label Jun 6, 2024
@driskull
Copy link
Member Author

driskull commented Jun 6, 2024

@jcfranco tests added

@driskull driskull merged commit 12407eb into main Jun 6, 2024
11 checks passed
@driskull driskull deleted the dris0000/action-bar-messages-label branch June 6, 2024 22:43
@github-actions github-actions bot added this to the 2024-06-25 - Jun Release milestone Jun 6, 2024
benelan added a commit that referenced this pull request Jun 10, 2024
…orkflow

* origin/main: (26 commits)
  revert: refactor: add simpler `componentFocusable` util (deprecates `LoadableComponent`) (#9515)
  chore(linting): enable selector-pseudo-element-colon-notation rule (#9518)
  refactor(storybook): refactor tooltip simple story interface (#9538)
  refactor(dom): consolidate transition/animation waiting utils (#9341)
  refactor(storybook): build storybook simple story args interfaces using component class (#9457)
  chore: release next
  fix(block): add accessible label for slotted controls (#9502)
  feat(action-bar, action-pad): add expandLabel and collapseLabel to messages (#9497)
  chore: release next
  feat(action-menu, combobox, dropdown, input-date-picker, popover): allow logical placements for flipPlacements property. #8825 (#9490)
  fix(popover): correct border radius on close button (#9485)
  fix(list-item): hide nested list items by default (#9474)
  refactor: move component types into component specific interfaces files (#9527)
  chore: release next
  fix(alert): pause auto-close alert when link focused (#9503)
  refactor(storybook): consolidate storybook and component types (#9500)
  refactor(calcite-block-section,calcite-card): consolidate interfaces imports (#9517)
  chore: release next
  fix(block-section): restore block toggling when clicking on the header switch (#9472)
  chore: release next
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants