Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action slots on non-collapsible blocks have mechanism to tie back to heading for unique identifier #8037

Closed
2 of 5 tasks
FelFly opened this issue Oct 20, 2023 · 2 comments
Closed
2 of 5 tasks

Action slots on non-collapsible blocks have mechanism to tie back to heading for unique identifier #8037

FelFly opened this issue Oct 20, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. ArcGIS Hub Issues logged by ArcGIS Hub team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-06-25 - Jun ...

Comments

@FelFly
Copy link

FelFly commented Oct 20, 2023 •
edited
Loading

Check existing issues

Summary

Per the Link Purpose guideline 2.4.4., I'm trying to avoid having multiple calcite-action buttons labeled the same exact thing, but given the actions are the same in several consecutive blocks and only the heading changes, I'd like to tie the actions to the heading via aria-labelledby for context.

Actual Behavior

When I try to use aria-labelledby on the action slots in a non-collapsible block with a reference ID set on the heading of the block, I don't hear any type of relationship in NVDA or VoiceOver (it does work fine in JAWS). https://codepen.io/FelFly/pen/poxVNBv

Expected Behavior

What I'd hope to hear is the title associated with the action slots, so for the remove buttons, I'd hear "remove, button, raccoons eating twizzlers" and "remove, button, all the puppies," which would help differentiate the buttons and provide more context when accessed from form shortcut menus for screen readers.

Kitty says this was fixed for collapsible blocks: #7652, so this issue is simply to extend the fix to non-collapsible blocks.

Reproduction Sample

https://codepen.io/FelFly/pen/poxVNBv

Reproduction Steps

  1. In NVDA on Firefox, navigate into block

  2. Navigate to the action links (open in new tab, remove) via tab for each of the two blocks

  3. In VoiceOver, navigate into block (Ctrl+Option+right-arrow)

  4. Navigate to action links (open in new tab, remove) via Ctrl+Option+right-arrow for each of the two blocks

Reproduction Version

1.9.2

Working W3C Example/Tutorial

No response

Relevant Info

NVDA tested on Firefox in Windows 10 in Parallels, VoiceOver tested with Chrome (something about my codepen kept crashing Safari) on Mac Ventura 13.6.

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Hub
@FelFly FelFly added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. p - high Issue should be addressed in the current milestone, impacts component or core functionality labels Oct 20, 2023
@github-actions github-actions bot added p3 - want for upcoming milestone ArcGIS Hub Issues logged by ArcGIS Hub team members. calcite-components Issues specific to the @esri/calcite-components package. labels Oct 20, 2023
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed p - high Issue should be addressed in the current milestone, impacts component or core functionality needs triage Planning workflow - pending design/dev review. labels Nov 27, 2023
@geospatialem geospatialem added this to the 2024-04-24 - Apr Release milestone Jan 10, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 10, 2024
@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
@driskull driskull self-assigned this Jun 3, 2024
driskull added a commit that referenced this issue Jun 3, 2024
@driskull
fix(block): add aria-describedby for slotted controls. #8037
7f5ed3a
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jun 3, 2024
@driskull driskull mentioned this issue Jun 3, 2024
Merged
driskull added a commit that referenced this issue Jun 6, 2024
@driskull @geospatialem
fix(block): add accessible label for slotted controls (#9502)
a9054d5 
**Related Issue:** #8037

## Summary

- Add aria-labelledby to internal control container for enhanced
accessibility.

---------

Co-authored-by: Kitty Hurley <khurley@esri.com>
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 7, 2024
@geospatialem
Copy link
Member

Verified in 2.10.0-next.1 with https://codepen.io/FelFly/pen/poxVNBv and JAWS.

However, Calcite is unable to provide support to NVDA, where NVDA and the shadow DOM conflict with aria-named attributes similar to what is outline in this post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. ArcGIS Hub Issues logged by ArcGIS Hub team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
4 participants
@driskull @geospatialem @FelFly @DitwanP