fix(block): provide textual name on collapse and expansion to AT #7652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
geospatialem
added
the
pr ready for visual snapshots
anveshmekala
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Awesome @geospatialem !👏
Working as expected in VoiceOver with Safari 16.6.
Discussed with kitty regarding the need for title attribute since heading is a required prop. Though VoiceOver ignores title but JAWS does include it in the context.
jcfranco
approved these changes
Sep 1, 2023
geospatialem
deleted the
geospatialem/5565-block-description-expand-collapse
branch
Merged
geospatialem
modified the milestones:
2023 September Priorities - Main release,
1.7.1 Maintenance Release
geospatialem
added
the
low risk
benelan
added a commit
that referenced
this pull request
Sep 1, 2023
* origin/main: (35 commits) ci: make sure to exit on maitenance milestone failure (#7656) chore: release next fix(block): provide textual name on collapse and expansion to AT (#7652) chore: release main (#7571) chore: release next fix(block, block-section): improve a11y (#7557) chore: release next fix: add drag styles for improved UX (#7644) fix(input, input-number): correctly sanitize numbers when pasting string with 'e' (#7648) chore: release next feat(flow): add support for custom flow-item elements (#7608) chore: release next fix(list, sortable-list, value-list): Emit calciteListOrderChange when dragging between lists (#7614) feat(input-number): add integer property (#7646) chore: release next fix(accordion, accordion-item): improve a11y (#7560) refactor(stepper, stepper-item): `getElementProp` is refactored out in favor of inheritable props set directly on parent (#7593) docs(contributing): update the commit message format example URL (#7641) chore: release next feat(input-date-picker): normalize year to current century for user typed values only (#7638) ...
jcfranco
pushed a commit
that referenced
this pull request
Sep 7, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 1.8.0</summary> ## [1.8.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@1.7.0...@esri/calcite-components@1.8.0) (2023-09-06) ### Features * **flow:** Split up custom flow item interfaces ([#7666](#7666)) ([6c22e7c](6c22e7c)) ### Bug Fixes * **action-group:** Honor flex-grow on slotted actions ([#7690](#7690)) ([0777234](0777234)) * **block:** Provide textual name on collapse and expansion to AT ([#7652](#7652)) ([85bd71b](85bd71b)) * **input-date-picker:** Apply default numbering system to avoid browser inferring from locale ([#7682](#7682)) ([3e1ed2d](3e1ed2d)) * **input-time-zone:** Prevent items from being deselected ([#7661](#7661)) ([c2dd436](c2dd436)) * **list-item:** Do not call preventDefault on enter key within slotted actions ([#7684](#7684)) ([c3261f0](c3261f0)) * **list:** Remove unnecessary z-index ([#7678](#7678)) ([1f4cd97](1f4cd97)) * **modal:** CalciteModalClose should emit on close button click ([#7680](#7680)) ([796bf90](796bf90)) * **sheet:** CalciteSheetClose should emit on scrim click ([#7685](#7685)) ([6ae963e](6ae963e)) * **sheet:** Update shadow style in display-mode="float" ([#7664](#7664)) ([851bedb](851bedb)) * **table:** Allow wrapping text in table-header and table-cell ([#7665](#7665)) ([15cb2bf](15cb2bf)) * **time-picker:** Focus corresponding input when nudge buttons are clicked ([#7650](#7650)) ([9c7d846](9c7d846)) </details> <details><summary>@esri/calcite-components-react: 1.8.0</summary> ## [1.8.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@1.7.0...@esri/calcite-components-react@1.8.0) (2023-09-06) ### Bug Fixes * Resolve vite errors due to using expressions in dynamic imports ([#7671](#7671)) ([b4c1038](b4c1038)) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^1.8.0-next.2 to ^1.8.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5565
Summary
Prior to this proposed fix, NVDA and JAWS were only receiving context that the
blockwas expanded or collapsed due to thetitleprop.Updates include:
aria-describedbyto provide context of the collapse/expansion in addition to the header (handled via theid)"header"idto the block'sresources.ts