Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox: When you tab into the input, the options do not appear #9401

Closed
3 of 6 tasks
noahmulfinger opened this issue May 22, 2024 · 3 comments
Closed
3 of 6 tasks

Combobox: When you tab into the input, the options do not appear #9401

noahmulfinger opened this issue May 22, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
3 - installed Issues that have been merged to master branch and are ready for final confirmation. a11y Issues related to Accessibility fixes or improvements. ArcGIS Developer Experience Issues logged by ArcGIS Developer Experience team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. calcite-components-react Issues specific to the @esri/calcite-components-react package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-08-27 - Aug ...

Comments

@noahmulfinger
Copy link
Contributor

Check existing issues

Actual Behavior

Tabbing into the input causes the dropdown options to not appear, even when you start typing. This does not match the behavior after you click into the input.

Expected Behavior

I would expect to be able to see the filtered results whether I click on the combobox or tab into it.

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/combobox/

Reproduction Steps

  1. Tab into the combobox input.
  2. Start typing. You will not see the dropdown with matching options appear no matter what you type.
  3. Once you click on the the combobox, the options will start appearing.

Reproduction Version

2.8.2

Relevant Info

Tested in Chrome and Firefox.

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Developer Experience
@noahmulfinger noahmulfinger added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 22, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive calcite-components-react Issues specific to the @esri/calcite-components-react package. ArcGIS Developer Experience Issues logged by ArcGIS Developer Experience team members. labels May 22, 2024
@jcfranco jcfranco mentioned this issue May 25, 2024
Open
6 tasks
@jcfranco
Copy link
Member

We should definitely display any matched options when typing after tabbing into the component.

Not opening on focus is by design. This approach adheres to WAI-ARIA combobox guidance and is consistent with similar components (e.g., input-date-picker, input-time-picker). cc @geospatialem

@geospatialem geospatialem added a11y Issues related to Accessibility fixes or improvements. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. labels May 28, 2024
@geospatialem geospatialem added this to the 2024-08-27 - Aug Release milestone May 28, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label May 28, 2024
driskull added a commit that referenced this issue Jun 8, 2024
@driskull
fix(combobox): open the combobox when typing. #9401
96a55a1
@driskull driskull mentioned this issue Jun 8, 2024
Merged
@driskull driskull self-assigned this Jun 8, 2024
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jun 8, 2024
driskull added a commit that referenced this issue Jun 10, 2024
@driskull
fix(combobox): open the component when typing within it (#9543)
ab09c71 
**Related Issue:** #9401

## Summary

- Toggles the combobox's open property when typing within the input
- If the value.length > 0, the combobox is opened otherwise its closed
- adds test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Jun 12, 2024

🥭 Verified locally on dev

@DitwanP DitwanP closed this as completed Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
3 - installed Issues that have been merged to master branch and are ready for final confirmation. a11y Issues related to Accessibility fixes or improvements. ArcGIS Developer Experience Issues logged by ArcGIS Developer Experience team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. calcite-components-react Issues specific to the @esri/calcite-components-react package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-08-27 - Aug Release
Development

No branches or pull requests
5 participants
@jcfranco @driskull @geospatialem @noahmulfinger @DitwanP