Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): open the component when typing within it #9543

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

driskull
Copy link
Member

@driskull driskull commented Jun 8, 2024

Related Issue: #9401

Summary

  • Toggles the combobox's open property when typing within the input
  • If the value.length > 0, the combobox is opened otherwise its closed
  • adds test

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jun 8, 2024
@driskull driskull changed the title fix(combobox): open when typing within fix(combobox): open the component when typing within it Jun 8, 2024
@driskull driskull marked this pull request as ready for review June 8, 2024 00:17
@driskull driskull requested a review from a team as a code owner June 8, 2024 00:17
@benelan benelan changed the base branch from main to dev June 10, 2024 09:06
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a few comments, this LGTM!

@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jun 10, 2024
@driskull driskull merged commit ab09c71 into dev Jun 10, 2024
12 checks passed
@driskull driskull deleted the dris0000/combobox-open-on-keydown branch June 10, 2024 21:06
@github-actions github-actions bot added this to the 2024-06-25 - Jun Release milestone Jun 10, 2024
benelan added a commit that referenced this pull request Jun 10, 2024
* origin/dev:
  build(deps): update dependency markdownlint-cli to v0.41.0 (#9531)
  chore: add translations (#9461)
  build(deps): update dependency @whitespace/storybook-addon-html to v6.1.1 (#9510)
  build(deps): update dependency chromatic to v11.5.3 (#9519)
  build(deps): update dependency jsdom to v24.1.0 (#9530)
  build(deps): update dependency semver to v7.6.2 (#9508)
  build(deps): update dependency dayjs to v1.11.11 (#9452)
  build: update browserslist db (#9528)
  build(deps): update dependency @cspell/eslint-plugin to v8.8.4 (#9509)
  build(deps): update dependency quicktype-core to v23.0.170 (#9507)
  fix(combobox): open the component when typing within it (#9543)
  feat(split-button): add placement and flipPlacements property (#9548)
  ci(prerelease): use absolute path to publish script (#9546)
  ci: rework release workflow making dev the default branch (#9514)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants