Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(input-time-zone): add offsetStyle prop #9426

Merged
merged 40 commits into from
Jun 25, 2024
Merged

feat(input-time-zone): add offsetStyle prop #9426

merged 40 commits into from
Jun 25, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented May 25, 2024 •
edited
Loading

Related Issue: #8716

Summary

Adds offsetStyle prop to specify whether offset should always use UTC or GMT for the offset label instead of using the user's locale. Valid options are:

  • "user" uses UTC or GMT depending on the user's locale,
  • "gmt" always uses GMT, and
  • "utc" always uses UTC.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label May 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jun 5, 2024
@benelan benelan changed the base branch from main to dev June 10, 2024 09:11
@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Jun 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jun 18, 2024
@jcfranco jcfranco changed the title feat(input-time-zone): add offsetStyle prop feat(input-time-zone): add offsetStyle prop Jun 21, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jun 21, 2024
@jcfranco jcfranco marked this pull request as ready for review June 21, 2024 21:57
@jcfranco jcfranco requested a review from a team as a code owner June 21, 2024 21:57
driskull
driskull approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐟 👍

packages/calcite-components/src/components/alert/alert.scss Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Jun 23, 2024
@jcfranco
test failing assertion
daa6b3c
@jcfranco
restore global error checking
999ad14
@jcfranco
restore assertion
59210d2
@jcfranco
remove test filter for debugging
ce96130
@jcfranco
filter tests for CI debuggging
7970206
@jcfranco
add custom error logging
389f37c
@jcfranco
only offsetStyle
24ba79e
@jcfranco
omit one lang change for testing
9fc77bd
@jcfranco
remove all lang again
03aa5eb
@jcfranco
skip assertions
93528cc
@jcfranco
skip assertions
659a556
@jcfranco
remove custom error logging and restore all but one langs
63514ca
@jcfranco
skip assertions
e1a3caf
@jcfranco
restore assertions, remove langs
6973413
@jcfranco
remove unused vars
2eaa4d9
@jcfranco
restore offsetStyle tests and skip to test others
3e569e5
@jcfranco
restore single offsetStyle test
5da7580
@jcfranco
remove offsetStyle skip
396ef09
@jcfranco
test invalid assertion
502e597
@jcfranco
add dummy assertion to sniff out error
7b1cf5d
@jcfranco
restore assertion and add emulated time zone
d74e6c4
@jcfranco
ensure time zone is emulated for all tests and restore offsetStyle tests
28a401b
@jcfranco
remove test filter
b58de84
@jcfranco
tidy up
576e5b5
@jcfranco jcfranco added skip visual snapshots Pull requests that do not need visual regression testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jun 25, 2024
@jcfranco jcfranco merged commit dbc6c81 into dev Jun 25, 2024
11 checks passed
@jcfranco jcfranco deleted the jcfranco/8716-add-offset-display-prop-for-offset-labels branch June 25, 2024 03:21
@github-actions github-actions bot added this to the 2024-06-25 - Jun Release milestone Jun 25, 2024
benelan added a commit that referenced this pull request Jun 25, 2024
@benelan
Merge remote-tracking branch 'origin/dev' into benelan/8065-input-tim…
49a992a 
…e-min-max

* origin/dev:
  chore: release next
  feat(input-time-zone): add `offsetStyle` prop (#9426)
  chore: release next
  feat(panel, flow-item): add `footer-start` and `footer-end` slots (#9374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@jcfranco jcfranco

Labels
enhancement Issues tied to a new feature or request. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcfranco @driskull