Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[calcite-split-button] Enhancement request to add a property to control dropdown placement #9542

Closed
3 of 6 tasks
doreenbrinkman opened this issue Jun 7, 2024 · 2 comments
Closed
3 of 6 tasks

[calcite-split-button] Enhancement request to add a property to control dropdown placement #9542

doreenbrinkman opened this issue Jun 7, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. calcite-components-react Issues specific to the @esri/calcite-components-react package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Milestone
2024-06-25 - Jun ...

Comments

@doreenbrinkman
Copy link

Check existing issues

Actual Behavior

Dropdown is placed automatically. It would be helpful to control the placement of the dropdown in the calcite-split-button.

Expected Behavior

Dropdown from calcite-split-button is able to be placed.

Reproduction Sample

https://codepen.io/doreenbrinkman/pen/QWRMEje

Reproduction Steps

  1. Run the sample which changes the placement to a more desired position
  2. Comment out the JS script code and see position before

Reproduction Version

2.8.3

Relevant Info

Examples of when placement is needed.

No placement:
image

With placement:
image

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

We have workarounds to the issue (using the JS code) but it would be nice to use a new property to control.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online
@doreenbrinkman doreenbrinkman added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Jun 7, 2024
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. calcite-components Issues specific to the @esri/calcite-components package. calcite-components-react Issues specific to the @esri/calcite-components-react package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Jun 7, 2024
@doreenbrinkman doreenbrinkman changed the title [calcite-split-button] Enhancement request to add a placement property to control dropdown placement [calcite-split-button] Enhancement request to add a property to control dropdown placement Jun 7, 2024
@driskull driskull self-assigned this Jun 10, 2024
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jun 10, 2024
@driskull driskull added this to the 2024-06-25 - Jun Release milestone Jun 10, 2024
@driskull driskull added estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive and removed needs triage Planning workflow - pending design/dev review. labels Jun 10, 2024
driskull added a commit that referenced this issue Jun 10, 2024
@driskull
feat(split-button): add placement and flipPlacements property. #9542
78b1aeb
@driskull driskull mentioned this issue Jun 10, 2024
Merged
driskull added a commit that referenced this issue Jun 10, 2024
@driskull
feat(split-button): add placement and flipPlacements property (#9548)
bc2c2c6 
**Related Issue:** #9542

## Summary

- add placement and flipPlacements property
- add tests
- add story
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned driskull Jun 10, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Jun 12, 2024

🍡 Verified locally on dev

@DitwanP DitwanP closed this as completed Jun 12, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. calcite-components-react Issues specific to the @esri/calcite-components-react package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
4 participants
@driskull @geospatialem @DitwanP @doreenbrinkman