-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(split-button): add placement and flipPlacements property #9548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
@@ -168,6 +176,31 @@ export const iconStartAndIconEnd = (): string => html` | |||
</div> | |||
`; | |||
|
|||
export const placementTopStart = (): string => html` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we could replace this and similar tests by enhancing the [floatingUI
common test helper](https://github.com/Esri/calcite-design-system/blob/main/packages/calcite-components/src/tests/commonTests/floatingUI.ts? If so, we can create a separate issue for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that makes sense as a separate issue. Can you create one?
* origin/dev: build(deps): update dependency markdownlint-cli to v0.41.0 (#9531) chore: add translations (#9461) build(deps): update dependency @whitespace/storybook-addon-html to v6.1.1 (#9510) build(deps): update dependency chromatic to v11.5.3 (#9519) build(deps): update dependency jsdom to v24.1.0 (#9530) build(deps): update dependency semver to v7.6.2 (#9508) build(deps): update dependency dayjs to v1.11.11 (#9452) build: update browserslist db (#9528) build(deps): update dependency @cspell/eslint-plugin to v8.8.4 (#9509) build(deps): update dependency quicktype-core to v23.0.170 (#9507) fix(combobox): open the component when typing within it (#9543) feat(split-button): add placement and flipPlacements property (#9548) ci(prerelease): use absolute path to publish script (#9546) ci: rework release workflow making dev the default branch (#9514)
Related Issue: #9542
Summary