Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combobox: do not open when no filtered results are shown #9617

Closed
2 of 6 tasks
driskull opened this issue Jun 17, 2024 · 2 comments
Closed
2 of 6 tasks

combobox: do not open when no filtered results are shown #9617

driskull opened this issue Jun 17, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Milestone
2024-06-25 - Jun ...

Comments

@driskull
Copy link
Member

Check existing issues

Actual Behavior

When typing in a combobox, it always opens when there is text

Expected Behavior

when typing in a combobox, it only opens when there are filtered items to show

Reproduction Sample

https://codepen.io/driskull/pen/mdYpZgq?editors=1000

Reproduction Steps

  1. open https://codepen.io/driskull/pen/mdYpZgq?editors=1000
  2. type "xskdlsdl" or some random characters to guarantee no matches
  3. notice how the combobox is open
  4. The combobox should not be open.

Reproduction Version

2.9.0

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A
@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 17, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Jun 17, 2024
@driskull driskull mentioned this issue Jun 17, 2024
Merged
@driskull driskull self-assigned this Jun 18, 2024
@driskull driskull added 2 - in development Issues that are actively being worked on. estimate - 2 Small fix or update, may require updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 18, 2024
@driskull driskull added this to the 2024-06-25 - Jun Release milestone Jun 18, 2024
driskull added a commit that referenced this issue Jun 18, 2024
@driskull
fix(combobox): only open when text exists and filtered items are pres…
9a7f443 
…ent (#9618)

**Related Issue:** #9617

## Summary

- if no filtered items are displayed, the combobox should not be opened
- adds test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 18, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Jun 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 20, 2024
@geospatialem
Copy link
Member

Verified in 2.10.0-next.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
3 participants
@driskull @geospatialem @DitwanP