Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combobox): only open when text exists and filtered items are present #9618

Merged
merged 4 commits into from
Jun 18, 2024
Merged

fix(combobox): only open when text exists and filtered items are present #9618

merged 4 commits into from
Jun 18, 2024

Conversation

driskull
Copy link
Member

@driskull driskull commented Jun 17, 2024 •
edited
Loading

Related Issue: #9617

Summary

  • if no filtered items are displayed, the combobox should not be opened
  • adds test

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jun 17, 2024
@driskull driskull marked this pull request as ready for review June 17, 2024 20:49
@driskull driskull requested a review from a team as a code owner June 17, 2024 20:49
jcfranco
jcfranco approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝
📝🔍📝📝📝🔍🔍🔍🔍📝🔍🔍🔍🔍🔍📝🔍📝📝📝🔍📝🔍📝
📝🔍📝📝📝🔍📝📝📝📝📝📝🔍📝📝📝🔍🔍📝🔍🔍📝🔍📝
📝🔍📝📝📝🔍📝🔍🔍📝📝📝🔍📝📝📝🔍📝🔍📝🔍📝🔍📝
📝🔍📝📝📝🔍📝📝🔍📝📝📝🔍📝📝📝🔍📝📝📝🔍📝📝📝
📝🔍🔍🔍📝🔍🔍🔍🔍📝📝📝🔍📝📝📝🔍📝📝📝🔍📝🔍📝
📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝

packages/calcite-components/src/components/combobox/combobox.tsx Show resolved Hide resolved
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jun 18, 2024
@driskull driskull merged commit 9a7f443 into dev Jun 18, 2024
12 checks passed
@driskull driskull deleted the dris0000/combobox-fix-value branch June 18, 2024 23:52
@github-actions github-actions bot added this to the 2024-06-25 - Jun Release milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@driskull @jcfranco