Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(combobox): add filterText prop #9654

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

jcfranco
Copy link
Member

Related Issue:* #7212

Summary

Adds filterText to allow dynamic access to filter text.

@jcfranco jcfranco requested a review from a team as a code owner June 21, 2024 00:41
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Jun 21, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jun 21, 2024
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

We should probably add matchFields to combobox at some point as well.

@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jun 21, 2024
@jcfranco jcfranco merged commit 01d01de into dev Jun 21, 2024
14 checks passed
@jcfranco jcfranco deleted the jcfranco/7212-add-filterText-to-combobox branch June 21, 2024 20:33
@github-actions github-actions bot added this to the 2024-06-25 - Jun Release milestone Jun 21, 2024
benelan added a commit that referenced this pull request Jun 24, 2024
…rovements

* origin/dev:
  build(deps): update typescript-eslint monorepo to v7.13.1 (#9657)
  docs: update component READMEs (#9668)
  chore: release next
  chore: minor git tooling tweaks (#9664)
  feat(combobox): add `filterText` prop (#9654)
  chore: release next
  feat(list): add filterProps property to specify which properties to filter against (#9622)
  chore: release next
  fix(list): enable dragging on list items contained within a list that supports dragEnabled (#9660)
  test(filter): add coverage for empty filter text (#9655)
  chore: release next
  fix: set the correct Sortable parent when within a shadowRoot (#9532)
  fix(combobox): allow arrow selection of entered text (#9629)
@benelan benelan added autorelease: tagged Pull requests created by release-please that were merged and deployed and removed autorelease: tagged Pull requests created by release-please that were merged and deployed labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants