Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(input-date-picker, input-time-picker): support form validation for min/max constraints #9677

Merged
merged 6 commits into from
Jun 25, 2024
Merged

feat(input-date-picker, input-time-picker): support form validation for min/max constraints #9677

merged 6 commits into from
Jun 25, 2024

Conversation

benelan
Copy link
Member

@benelan benelan commented Jun 25, 2024

Related Issue: #8065, #9282

Summary

  • Add min and mix properties to calcite-input-time-picker

  • Add form validation support for min and max constraints to calcite-input-time-picker and calcite-input-date-picker

@benelan benelan requested a review from a team as a code owner June 25, 2024 08:54
@benelan
Merge remote-tracking branch 'origin/dev' into benelan/8065-input-tim…
49a992a 
…e-min-max

* origin/dev:
  chore: release next
  feat(input-time-zone): add `offsetStyle` prop (#9426)
  chore: release next
  feat(panel, flow-item): add `footer-start` and `footer-end` slots (#9374)
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Jun 25, 2024
driskull
driskull approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@benelan
test: fix input type
e0984f2
@benelan
Merge remote-tracking branch 'origin/dev' into benelan/8065-input-tim…
58be1ed 
…e-min-max

* origin/dev:
  build(deps): update dependency eslint-plugin-jsdoc to v48.2.13 (#9678)
  ci(release): reduce need for manual intervention (#9672)
  build(deps): update dependency eslint-plugin-react to v7.34.3 (#9669)
  build(deps): update dependency @cspell/eslint-plugin to v8.9.1 (#9670)
@benelan benelan added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jun 25, 2024
@benelan benelan merged commit 38fd878 into dev Jun 25, 2024
12 checks passed
@benelan benelan deleted the benelan/8065-input-time-min-max branch June 25, 2024 17:21
@github-actions github-actions bot added this to the 2024-06-25 - Jun Release milestone Jun 25, 2024
@benelan benelan added autorelease: tagged Pull requests created by release-please that were merged and deployed and removed autorelease: tagged Pull requests created by release-please that were merged and deployed labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@benelan benelan

Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benelan @driskull