Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(textarea): add default message bundle #5870

Merged
merged 4 commits into from
Dec 5, 2022
Merged

feat(textarea): add default message bundle #5870

merged 4 commits into from
Dec 5, 2022

Conversation

anveshmekala
Copy link
Contributor

Related Issue: #863

Summary

This PR will add default message bundle for calcite-textarea component.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Dec 1, 2022
@anveshmekala anveshmekala marked this pull request as ready for review December 2, 2022 22:32
@anveshmekala anveshmekala requested a review from a team as a code owner December 2, 2022 22:32
driskull
driskull approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/components/textarea/assets/textarea/t9n/messages.json Outdated Show resolved Hide resolved
@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 5, 2022
@driskull driskull merged commit c7a8495 into master Dec 5, 2022
@driskull driskull deleted the anveshmekala/863-add-default-message-bundle branch December 5, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geospatialem geospatialem geospatialem left review comments

@driskull driskull driskull approved these changes

Assignees

@anveshmekala anveshmekala

Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
Sprint 2022/12/04 - 2022/12/15
Development

Successfully merging this pull request may close these issues.
3 participants
@anveshmekala @driskull @geospatialem