-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tooltip, popover, input-date-picker): onToggleOpenCloseComponent
replaces connect logic
#7358
Merged
Elijbet
merged 6 commits into
main
from
elijbet/6018-popover-tooltip-input-date-picker-onToggleOpenCloseComponent-replaces-connect-logic
Jul 24, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nent replaces connect logic
…er-onToggleOpenCloseComponent-replaces-connect-logic
Elijbet
added
the
refactor
Issues tied to code that needs to be significantly reworked.
label
Jul 21, 2023
Elijbet
added
the
skip visual snapshots
Pull requests that do not need visual regression testing.
label
Jul 21, 2023
…er-onToggleOpenCloseComponent-replaces-connect-logic
driskull
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These code changes look good to me 👍
jcfranco
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This should be good to merge once comment(s) are addressed.
…er-onToggleOpenCloseComponent-replaces-connect-logic
Elijbet
deleted the
elijbet/6018-popover-tooltip-input-date-picker-onToggleOpenCloseComponent-replaces-connect-logic
branch
July 24, 2023 22:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
refactor
Issues tied to code that needs to be significantly reworked.
skip visual snapshots
Pull requests that do not need visual regression testing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6018
Summary
Use the new
onToggleOpenCloseComponent
pattern to replace bothconnectOpenCloseComponent
anddisconnectOpenCloseComponent
ontooltip
,popover
, andinput-date-picker
. This new pattern is intended to simplify the overall eventing logic.